Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to google-resumable-media in BigQuery. #3555

Merged
merged 10 commits into from
Jul 21, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jun 27, 2017

@jonparrott Asked that I make a "do not merge" PR out of this, as a placeholder for the work remaining in #1998.

When I wrote this code (May 10th), the system tests all passed without issue (THAT WAS NOT TRUE WHEN I WROTE IT), but the unit tests are currently very broken by this change.

I am very much intentionally leaving the "Allow edits from maintainers" box checked, so anyone is free to fix the unit tests 😀

@dhermes dhermes added api: bigquery Issues related to the BigQuery API. hygiene do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 27, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2017
@theacodes theacodes added DevEx and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 20, 2017
@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2017

OK after some work last night by @jonparrott and by me this AM, the unit tests are passing at 100%.

I'm fairly certain there will be a system test breakage though. I seem to recall the getting the size from the final 200 response of a finished resumable upload is "impossible" with the BigQuery API. (The real story: I assumed all APIs would return size because Storage did, it may have been a bad assumption.)

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

w00t! I confirmed the system tests pass locally:

$ nox -s "system_tests(python_version='2.7')"
nox > Running session system_tests(python_version='2.7')
nox > virtualenv .../bigquery/.nox/sys-2-7 -p python2.7
nox > chdir .../bigquery
nox > pip install --upgrade mock pytest ../core
nox > pip install --upgrade ../storage ../test_utils
nox > pip install --upgrade .
nox > py.test --quiet tests/system.py
.........................
25 passed in 163.06 seconds
nox > Session system_tests(python_version='2.7') successful. :)
$
$
$ nox -s "system_tests(python_version='3.6')"
nox > Running session system_tests(python_version='3.6')
nox > virtualenv .../bigquery/.nox/sys-3-6 -p python3.6
nox > chdir .../bigquery
nox > pip install --upgrade mock pytest ../core
nox > pip install --upgrade ../storage ../test_utils
nox > pip install --upgrade .
nox > py.test --quiet tests/system.py
.........................
25 passed in 155.69 seconds
nox > Session system_tests(python_version='3.6') successful. :)

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

OK CircleCI is green. Let's merge?!?

@dhermes dhermes merged commit c5ccca1 into googleapis:master Jul 21, 2017
@dhermes dhermes deleted the bigquery-remove-streaming branch July 21, 2017 21:41
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
* Switched to google-resumable-media in BigQuery.
* Upgrading google-resumable-media dependency to 0.2.1.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
* Switched to google-resumable-media in BigQuery.
* Upgrading google-resumable-media dependency to 0.2.1.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
* Switched to google-resumable-media in BigQuery.
* Upgrading google-resumable-media dependency to 0.2.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants