-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.6.0 #600
Merged
Merged
Release v1.6.0 #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used to provision A2 machine types, using the empty list as the default value of guest_accelerator causes a permadiff because the Compute Engine API reports the A2's A100 GPU card and we have chosen an explicit value. If, instead, we use a null value for guest_accelerator, Terraform treats the difference as not requiring action.
Add customized version output for debugging improvement
Exposing enable_reconfigure in Slurm-onGCP V5
Adding Slurm on GCP V4 static nodes functionality
Previously the scope for the vm only allowed it to read from GCS. Now both read and writes are allowed.
Set enable_smt default to false for slurm v5 modules
Run shell runners as executable
Updates the schedmd-slurm-gcp-v5-hybrid module to default the `slurm_cluster_name` to a filtered version of the `deployment_name` if not explicitly provided. Implementation matches that of login and controller modules.
…-disk Add auto-delete boot disk as an option on vm-instance
Default slurm_cluster_name to deploy name in hybrid
Default scope now allows reading AND writing.
Updated the install path sed command to also catch EpilogSlurmctld and PrologSlurmctld when exclusive partitions are being used. Updated the hybrid test config to include an exclusive partition and to reformat module definitions in line with recent improvements in the codebase.
Upgrade DDN-EXAScaler to v6.1.0
Creation of the group level directory was skipped previously, as it was handled in non-git sources automatically. With git sources, it needs to be created, so this commit adds that logic before handling modules directly in copySource.
Enable DDN Lustre client install with pre-existing-network-storage
Changes the deployment_name and therefore slurm_cluster_name so that the hostname of the controller will be cleaner looking and allow us to include the name directly in the instructions. In addition, other reviewer feedback is addressed by this commit.
Breaks the group directory creation into a separate function from copySource. This allow for better testing and better separation of tasks. Tests have been written to ensure directories are created correctly.
Allow generic git sources
Add hybrid slurm demo example using 2 GCP projects.
Use fully-qualified Ansible module names where not used
Perform regular cleanup of Filestore VPC network peerings
- do not attempt to re-create a Spack environment that already exists
Avoid spurious errors in Spack log
Fix remove default urls
Fix filestore peering network cleanup script
Update version to 1.6.0
nick-stroud
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
pre-commit install
)make tests
)