Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filestore peering network cleanup script #569

Conversation

tpdownes
Copy link
Member

The filestore network peering script failed over the weekend due to an apparent parsing error. The solution worked for me locally before submitting, but I am providing what is likely a more portable fix by explicitly reading in a bash array using read -ra. The commenting is also improved to guide future developers understanding the solution.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out on my end, and everything seems to work as expected (at least locally). LGTM

@heyealex heyealex assigned tpdownes and unassigned heyealex Sep 26, 2022
@tpdownes tpdownes merged commit 79a27ed into GoogleCloudPlatform:develop Sep 26, 2022
@tpdownes tpdownes deleted the fix_filestore_peering_limit_script branch September 26, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants