Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set enable_smt default to false for slurm v5 modules #545

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Set enable_smt default to false for slurm v5 modules #545

merged 1 commit into from
Sep 13, 2022

Conversation

heyealex
Copy link
Contributor

Brings the default in line with slurm-gcp v4 modules, which turned off hyperthreading (SMT) by default.
Tested against the slurm-gcp-v5-hpc-centos7 community example.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@heyealex heyealex requested a review from tpdownes September 13, 2022 18:43
@heyealex heyealex merged commit 02cbdbf into GoogleCloudPlatform:develop Sep 13, 2022
@heyealex heyealex deleted the smt-default-slurm-gcp-v5 branch September 13, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@tpdownes tpdownes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyealex @tpdownes