Add manifest fields for PWA install bottom sheet #933
Conversation
| description: | ||
| 'Compress and compare images with different codecs, right in your browser.', | ||
| lang: 'en', | ||
| categories: ['photo', 'productivity', 'utilities'], |
There was a problem hiding this comment.
@beaufortfrancois are these from a particular list of categories?
There was a problem hiding this comment.
Indeed. it comes from https://github.com/w3c/manifest/wiki/Categories#standardized-categories
There was a problem hiding this comment.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
@beaufortfrancois I've switch the images to webp so they're around a 10th of the size. Is webp ok to use here? |
|
WebP is still not supported on Android sadly. See https://source.chromium.org/chromium/chromium/src/+/master:components/webapps/browser/installable/installable_manager.cc;l=113;bpv=1;bpt=1?q=fetchScreenshot&ss=chromium and https://bugs.chromium.org/p/chromium/issues/detail?id=466958 |
This reverts commit c60d0d9.
|
@surma could you do a review of this? I've added quite a bit to it |
|
|
||
| const defaultOpts = { | ||
| prefix: 'url', | ||
| imagePrefix: 'img-url', |
There was a problem hiding this comment.
Cheeky suggestion: Wouldn’t it keep this plugin simpler if instead of a second prefix it would take a list of file extensions that we consider images?
There was a problem hiding this comment.
Hmm, that would make the typing a lot harder. RIght now the module definition is based on prefixes. What you're proposing would depend on both a prefix and a (set of) suffixes, and I don't think TS supports that.
I'll keep it explicit for now, but if the typing can be done, happy for it to change.
This PR adds standardized manifest fields for PWA install bottom sheet such as
description,lang,categories, andscreenshotsso that the PWA install bottom sheet looks great. See screenshot below.Note that it currently requires
chrome://flags/#mobile-pwa-install-use-bottom-sheetflag in Chrome Canary on Android.