Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Move some members to App Information Note #900

Merged
merged 29 commits into from
Jul 15, 2020

Conversation

aarongustafson
Copy link
Collaborator

@aarongustafson aarongustafson commented Jun 10, 2020

Closes #876

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Commit message:

This will migrate all store & enhanced installation-related members to a separate Note dedicated to their maintenance. If it makes more sense to move this Note to its own repository, we can do that instead.


Preview | Diff

@aarongustafson aarongustafson marked this pull request as draft June 10, 2020 19:45
@aarongustafson aarongustafson changed the title Breaking: App information Note Breaking: App Information Note Jun 10, 2020
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
@christianliebel
Copy link
Member

Review comments from above and ReSpec issues left aside, looks good to me and makes perfect sense. 👍

app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
app-information.html Outdated Show resolved Hide resolved
@aarongustafson
Copy link
Collaborator Author

Once the new repo is published, I think we switch this from draft to ready for review.

@aarongustafson aarongustafson marked this pull request as ready for review July 14, 2020 00:17
@aarongustafson aarongustafson requested a review from kenchris July 14, 2020 00:17
@aarongustafson
Copy link
Collaborator Author

@marcoscaceres What do I need to do to ensure the new spec’s exports get picked up?

@marcoscaceres
Copy link
Member

@marcoscaceres What do I need to do to ensure the new spec’s exports get picked up?

We need to first publish it on /TR/ - then it will get picked up from there.

@marcoscaceres marcoscaceres changed the title Breaking: App Information Note Editorial: Move some members to App Information Note Jul 15, 2020
@marcoscaceres marcoscaceres added the BLOCKED Blocked for some reason label Jul 15, 2020
@marcoscaceres
Copy link
Member

Blocked on publishing the App info document as a Note...

@aarongustafson aarongustafson merged commit c154531 into w3c:gh-pages Jul 15, 2020
@aarongustafson
Copy link
Collaborator Author

@marcoscaceres I don’t know exactly what happened here, I hit the button to update this PR from gh-pages (to be clear, not "Squash and Merge") and it squashed and merged instead. I can revert if needed. Let me know how to proceed here.

aarongustafson added a commit that referenced this pull request Jul 15, 2020
@marcoscaceres
Copy link
Member

No problem, I'll revert the changes and send them again.

@aarongustafson
Copy link
Collaborator Author

Thanks!

marcoscaceres added a commit that referenced this pull request Jul 17, 2020
marcoscaceres added a commit that referenced this pull request Jul 17, 2020
* Adding first pass app information note

* removing categories, description, screenshots, and iarc_rating

* Migrating processing steps

* tidy

* typo & acknowledgements

* Update app-information.html

Co-authored-by: Christian Liebel <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Recommended changes

* Removing the date

Co-authored-by: Marcos Cáceres <[email protected]>

* Change the section reference

* tidy

* Removed the intro example
Switched USVString to DOMString

* USVString ->  DOMString

* Properly accenting Marcos’ name

* Moved app-info into it’s own repo
https://github.com/w3c/manifest-app-info

* typo

* Typo

* Chore: Added note about migrating categories, description, IARC rating, and screenshots to Application Information

Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
@kenchris
Copy link
Collaborator

Are we going to reland this? @aarongustafson @marcoscaceres ? People are getting confused with there being an manifest-app-info spec and then the members are still in the main spec

@kenchris
Copy link
Collaborator

Chrome is impleenting support for app-info so it would be nice to solve this soon: GoogleChromeLabs/squoosh#933

aarongustafson added a commit that referenced this pull request Jan 19, 2021
* Editorial: Move some members to App Information Note (#900)

* Adding first pass app information note

* removing categories, description, screenshots, and iarc_rating

* Migrating processing steps

* tidy

* typo & acknowledgements

* Update app-information.html

Co-authored-by: Christian Liebel <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Update app-information.html

Co-authored-by: Marcos Cáceres <[email protected]>

* Recommended changes

* Removing the date

Co-authored-by: Marcos Cáceres <[email protected]>

* Change the section reference

* tidy

* Removed the intro example
Switched USVString to DOMString

* USVString ->  DOMString

* Properly accenting Marcos’ name

* Moved app-info into it’s own repo
https://github.com/w3c/manifest-app-info

* typo

* Typo

* Chore: Added note about migrating categories, description, IARC rating, and screenshots to Application Information

Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>

* Updating the link to the App Info spec

Co-authored-by: Marcos Cáceres <[email protected]>

* Removing links that are not exported.

Co-authored-by: Marcos Cáceres <[email protected]>

Co-authored-by: Aaron Gustafson <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED Blocked for some reason refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove store metadata into own spec or note?
5 participants