This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Add manifest fields for PWA install bottom sheet #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. ✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨ |
|
Deploy preview for web-dev-staging ready! Built with commit b13928b |
beaufortfrancois
force-pushed
the
manifest-update
branch
from
3e62044 to
b13928b
Compare
beaufortfrancois
force-pushed
the
manifest-update
branch
from
62c423e to
b13928b
Compare
beaufortfrancois
changed the title
|
@robdodson Can you review? |
robdodson
approved these changes
Jan 21, 2021
beaufortfrancois
added
the
content update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following GoogleChromeLabs/squoosh#933 and #4502, this PR adds standardized manifest fields for PWA install bottom sheet such as description, lang, categories, and screenshots so that the PWA install bottom sheet looks great. See screenshot below.
Note that it currently requires
chrome://flags/#mobile-pwa-install-use-bottom-sheetflag in Chrome Canary on Android.