Fix button boost behaviour

[kkatusic]

• Create flow for verifying email ownership on profile creation and edit #4476

Summary by CodeRabbit

• New Features
  • Enhanced boost action logic to check email verification status for all users, improving accessibility for both admin and non-admin users.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 2, 2024 0:44am

[coderabbitai]

Walkthrough

The changes in this pull request focus on the ProjectGIVbackToast component, specifically modifying the handleBoostClick function. The condition for checking email verification status has been updated to utilize a new variable, isEmailVerifiedStatus, which allows for a more inclusive check for both admin and non-admin users. This adjustment enhances the logic governing the boost action based on user email verification without altering the overall structure or functionality of the component.

Changes

File Path	Change Summary
src/components/views/project/ProjectGIVbackToast.tsx	Updated email verification condition in handleBoostClick from isAdminEmailVerified to isEmailVerifiedStatus.

Possibly related PRs

• Fixing statuses for unverified email #4879: Modifies the ProjectGIVbackToast component to streamline the handling of email verification status.
• Fixing notification condition #4881: Addresses notification conditions related to project verification, connecting to the email verification logic.
• Fixing text translation for vouched users #4882: Updates text translations for GIVbacks eligibility notifications, aligning with the email verification status changes.

Suggested labels

Code Review

Suggested reviewers

• CarlosQ96
• MohammadPCh

🐰 In the garden of code, I hop with glee,
A tweak here and there, for all to see.
With emails verified, the boosts will flow,
A sprinkle of logic, watch the features grow!
Hooray for the changes, let's give a cheer,
For every small update brings us near! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

src/components/views/project/ProjectGIVbackToast.tsx (2)

80-80: LGTM! Consider adding a comment for the email verification check.

The email verification check is correctly implemented, ensuring that admin users have verified emails before boosting while allowing non-admin users to proceed.

Consider adding a comment to explain the verification requirement:

+  // Only admin users need email verification
   if (!isEmailVerifiedStatus) return;

---

Line range hint 81-88: Consider adding tests for the email verification flow.

The boost click handler correctly integrates email verification with the existing authentication flow. To ensure this behavior remains correct:

Consider adding the following test cases:

1. Admin user with verified email can boost
2. Admin user without verified email cannot boost
3. Non-admin user can boost regardless of email verification

Would you like me to help create these test cases?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c69457a and a3bf85f.

📒 Files selected for processing (1)

• src/components/views/project/ProjectGIVbackToast.tsx (1 hunks)

🔇 Additional comments (1)

src/components/views/project/ProjectGIVbackToast.tsx (1)

Line range hint 391-394: LGTM! UI feedback for email verification is well implemented.

The UI provides clear feedback when email verification is required:

• Visual indication through opacity
• Functional blocking through pointer-events
• Helpful tooltip explaining the requirement

Also applies to: 396-398

[CarlosQ96]

Thanks Kkechy!