Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CodeGenOpt unit tests #2734

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Update CodeGenOpt unit tests #2734

merged 1 commit into from
Sep 28, 2023

Conversation

dstutt
Copy link
Member

@dstutt dstutt commented Sep 27, 2023

There is a flag-day change around CodeGen enums in llvm/llvm-project#66295.

Changes were made in #2770 but some unit tests were missed.

@dstutt
Update CodeGenOpt unit tests
2b079c9 
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295.

Changes were made in GPUOpen-Drivers#2770 but some
unit tests were missed.
@dstutt dstutt requested a review from piotrAMD September 27, 2023 09:47
@dstutt dstutt requested a review from a team as a code owner September 27, 2023 09:47
@jasilvanus
Copy link
Contributor

#2770

This should be #2707 instead.

@dstutt
Copy link
Member Author

dstutt commented Sep 27, 2023

#2770

This should be #2707 instead.

Doh. Thanks. I'll update the commit message appropriately when I submit it.

piotrAMD
piotrAMD approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@piotrAMD piotrAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM with the comment.

lgc/unittests/interface/OptLevelTest.cpp Show resolved Hide resolved
@amdvlk-admin
Copy link

Test summary for commit 2b079c9

CTS tests (Failed: 0/138993)
  • Built with version 1.3.5.2
    • Ubuntu 22.04, Navi3x
    • Passed: 41144/69503 (59.2%)
    • Failed: 0/69503 (0.0%)
    • Not Supported: 28359/69503 (40.8%)
    • Warnings: 0/69503 (0.0%)
    Ubuntu 20.04, Navi2x
    • Passed: 41178/69490 (59.3%)
    • Failed: 0/69490 (0.0%)
    • Not Supported: 28312/69490 (40.7%)
    • Warnings: 0/69490 (0.0%)

@dstutt dstutt merged commit 6ca60f4 into GPUOpen-Drivers:dev Sep 28, 2023
9 checks passed
@dstutt dstutt deleted the codegenopt-update branch September 28, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrAMD piotrAMD piotrAMD approved these changes

@Flakebi Flakebi Flakebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dstutt @jasilvanus @amdvlk-admin @Flakebi @piotrAMD