Fix an issue of missing handling DecorationComponent #2770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to handle DecorationComponent when calling LGC CreateReadGenericInput. This issue is not caught by normal CTS testing because we enable GS-FS packing. This issue occurs on GS-FS unpacking path. The GLSL is as follow: GS: layout(location = 0, component = 0, xfb_...) out float f0; layout(location = 0, component = 1) out float f1; // not xfb layout(location = 0, component = 2, xfb_...) out float f1; FS: layout(location = 0, component = 0) in float f0; layout(location = 0, component = 1) in float f1; layout(location = 0, component = 2) in float f1; During in-out matching, GS doesn't add f1 to active output list because FS forgets to record the component value of f1 (it is always component 0). GS couldn't find a matching FS input of f1. Meanwhile, f1 is not a xfb output. As a result, GS doesn't export f1 to FS and treats it to be an inactive output, leading to the final missing attribute export.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to handle DecorationComponent when calling LGC CreateReadGenericInput. This issue is not caught by normal CTS testing because we enable GS-FS packing. This issue occurs on GS-FS unpacking path. The GLSL is as follow:
GS:
FS:
During in-out matching, GS doesn't add f1 to active output list because FS forgets to record the component value of f1 (it is always component 0). GS couldn't find a matching FS input of f1. Meanwhile, f1 is not a xfb output. As a result, GS doesn't export f1 to FS and treats it to be an inactive output, leading to the final missing attribute export.