-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CodeGenOpt #2707
Update CodeGenOpt #2707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but fails formatting check.
c42cead
to
5b69909
Compare
Fixed formatting check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test summary for commit c42ceadCTS tests (Failed: 0/208496)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
Test summary for commit 5b69909CTS tests (Failed: 0/208496)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295. Update the code to use both old and new schemes depending on the LLVM version used. Change enum to uint32_t in some places to reduce the number of include guards.
5b69909
to
f9ad9ed
Compare
Test summary for commit f9ad9edCTS tests (Failed: 0/208497)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I think (most of?) this could have been done by adding a strategic using
directive that exists only in the old version of the code.
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295. Changes were made in #2707 but some unit tests were missed.
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295.
Update the code to use both old and new schemes depending on the LLVM version used.
Change enum to uint32_t in some places to reduce the number of include guards.