Add button to pause playlist after current video #3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
Benjababe
changed the title
4 tasks
|
You only need to add translations for See the README for more information: |
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Aug 28, 2023
static/locales/en_GB.yaml
Outdated
There was a problem hiding this comment.
Hi @Benjababe there is nothing wrong with the changes in this file but we like to only add the en-US translations and leave the rest to the other translators. Could u revert the changes u made to this file.
See #3938 (comment)
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
August 28, 2023 23:43
Head branch was pushed to by a user without write access
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
ChunkyProgrammer
added
PR: waiting for review
ChunkyProgrammer
approved these changes
Aug 31, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 6, 2023
PikachuEXE
approved these changes
Sep 7, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 7, 2023
* development: Add button to pause playlist after current video (FreeTubeApp#3938) Translated using Weblate (Greek) Translated using Weblate (Lithuanian) Translated using Weblate (Swedish) Translated using Weblate (Catalan) Make ft-channel-bubble an actual link when it is being used as one (FreeTubeApp#3980) Translated using Weblate (Catalan) Translated using Weblate (Catalan) Translated using Weblate (French) Bump lefthook from 1.4.9 to 1.4.10 (FreeTubeApp#4003) Bump the babel group with 3 updates (FreeTubeApp#4000) Bump actions/checkout from 3 to 4 (FreeTubeApp#3999) Group dependabot created updates for some packages in fewer PRs (FreeTubeApp#3968) Chore: Update vscode configurations (FreeTubeApp#3986) Bump youtubei.js from 6.1.0 to 6.3.0 (FreeTubeApp#3994) Bump postcss from 8.4.28 to 8.4.29 (FreeTubeApp#3995) Bump @babel/preset-env from 7.22.10 to 7.22.14 (FreeTubeApp#3996) Bump marked from 7.0.5 to 8.0.0 (FreeTubeApp#3993) Bump electron-builder from 24.6.3 to 24.6.4 (FreeTubeApp#3992) # Conflicts: # src/renderer/views/Watch/Watch.js
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 7, 2023
* feature/playlist-2023-05: (25 commits) ! Fix prompt style issue caused by old branch changes * Update single playlist view to only show `Remove watched videos` btn when there is any video Add button to pause playlist after current video (FreeTubeApp#3938) Translated using Weblate (Greek) Translated using Weblate (Lithuanian) Translated using Weblate (Swedish) Translated using Weblate (Catalan) Make ft-channel-bubble an actual link when it is being used as one (FreeTubeApp#3980) $ Remove unused and unusable playlist code for inserting video IDs into a playlist $ Remove unused mapActions entries * Make adding large no. of videos faster Translated using Weblate (Catalan) Translated using Weblate (Catalan) Translated using Weblate (French) Bump lefthook from 1.4.9 to 1.4.10 (FreeTubeApp#4003) Bump the babel group with 3 updates (FreeTubeApp#4000) Bump actions/checkout from 3 to 4 (FreeTubeApp#3999) Group dependabot created updates for some packages in fewer PRs (FreeTubeApp#3968) Chore: Update vscode configurations (FreeTubeApp#3986) Bump youtubei.js from 6.1.0 to 6.3.0 (FreeTubeApp#3994) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add button to pause playlist after current video
Pull Request Type
Related issue
Closes #2938
Description
Adds a pause button to playlist controls.
If enabled, when the current video finishes playing it will not autoplay the next video.
Will disable itself if its stopping condition is reached or when a new video is loaded
Screenshots
Testing
Tried on a couple of playlists and seemed fine.
Shouldn't cause crazy issues if there are any, only logic touched is when video finishes playing
Desktop