Make ft-channel-bubble an actual link when it is being used as one #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
PikachuEXE
approved these changes
Sep 1, 2023
ChunkyProgrammer
approved these changes
Sep 1, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 6, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 7, 2023
* development: Add button to pause playlist after current video (FreeTubeApp#3938) Translated using Weblate (Greek) Translated using Weblate (Lithuanian) Translated using Weblate (Swedish) Translated using Weblate (Catalan) Make ft-channel-bubble an actual link when it is being used as one (FreeTubeApp#3980) Translated using Weblate (Catalan) Translated using Weblate (Catalan) Translated using Weblate (French) Bump lefthook from 1.4.9 to 1.4.10 (FreeTubeApp#4003) Bump the babel group with 3 updates (FreeTubeApp#4000) Bump actions/checkout from 3 to 4 (FreeTubeApp#3999) Group dependabot created updates for some packages in fewer PRs (FreeTubeApp#3968) Chore: Update vscode configurations (FreeTubeApp#3986) Bump youtubei.js from 6.1.0 to 6.3.0 (FreeTubeApp#3994) Bump postcss from 8.4.28 to 8.4.29 (FreeTubeApp#3995) Bump @babel/preset-env from 7.22.10 to 7.22.14 (FreeTubeApp#3996) Bump marked from 7.0.5 to 8.0.0 (FreeTubeApp#3993) Bump electron-builder from 24.6.3 to 24.6.4 (FreeTubeApp#3992) # Conflicts: # src/renderer/views/Watch/Watch.js
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 7, 2023
* feature/playlist-2023-05: (25 commits) ! Fix prompt style issue caused by old branch changes * Update single playlist view to only show `Remove watched videos` btn when there is any video Add button to pause playlist after current video (FreeTubeApp#3938) Translated using Weblate (Greek) Translated using Weblate (Lithuanian) Translated using Weblate (Swedish) Translated using Weblate (Catalan) Make ft-channel-bubble an actual link when it is being used as one (FreeTubeApp#3980) $ Remove unused and unusable playlist code for inserting video IDs into a playlist $ Remove unused mapActions entries * Make adding large no. of videos faster Translated using Weblate (Catalan) Translated using Weblate (Catalan) Translated using Weblate (French) Bump lefthook from 1.4.9 to 1.4.10 (FreeTubeApp#4003) Bump the babel group with 3 updates (FreeTubeApp#4000) Bump actions/checkout from 3 to 4 (FreeTubeApp#3999) Group dependabot created updates for some packages in fewer PRs (FreeTubeApp#3968) Chore: Update vscode configurations (FreeTubeApp#3986) Bump youtubei.js from 6.1.0 to 6.3.0 (FreeTubeApp#3994) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ft-channel-bubble an actual link when it is being used as one
Pull Request Type
Description
The channel bubble component is used in 4 places, twice for channel selection on the profile edit page and as links on the channel about tab for the featured channels and errored channels on the subscriptions page. Currently we just set the role of the element to link (
role="link") but it doesn't act like other links in FreeTube, right, middle and control/command clicking does nothing.This pull request replaces the
role="link"in favour of using router-links, that way they behave as expected, meaning you can control/command and middle click on them to open the channel in a new window and right clicking brings up the context menu that allows you to copy the link or open it in a new window.Testing
Check that selecting and deselecting still work on the profile edit page, in both the "Subscriptions List" and "Other Channels" sections.
Check that the channel bubbles on the about tab of channels act as links, so clicking on them still takes you to the channel but also that the context menu with the copy link and open in new window entries show up.
Desktop