Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include hide comment photos setting #3939

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

Benjababe
Copy link
Contributor

@Benjababe Benjababe commented Aug 24, 2023

Include hide comment photos setting

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #3919

Description

Adds toggle switch to Settings>Distraction Free Settings>Watch Page>Hide Comment Photos
Essentially hides profile pictures in comments, replaces it with the default background color of the FreeTube profile on the top right (assuming styling is subject to change) and the first character of the commenter's username.

Livestream chat isn't affected, not sure to touch it or not.

Screenshots

image

Replaces this
image
with
image

Testing

Looked through a couple of videos and it seemed fine

Desktop

  • OS: Windows 10
  • OS Version: 22H2
  • FreeTube version:

Additional context

Same query with this PR about the i18n stuff.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 24, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 24, 2023 16:43
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 24, 2023

Not sure what the other think about this but IMO if the creator of the video places a comment its maybe better to see their profile picture for more visibility

I know their name is highlighted but that could be easily overlooked IMO

@kommunarr
Copy link
Collaborator

Not sure what the other think about this but IMO if the creator of the video places a comment its maybe better to see their profile picture for more visibility

I know their name is highlighted but that could be easily overlooked IMO

@robjob1938 Thoughts on this? I would personally agree with @efb4f5ff-1298-471a-8973-3d47447115dc, in that you would already be being presented with the video creator's thumbnail photo in the video info section anyway.

auto-merge was automatically disabled August 26, 2023 12:02

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 26, 2023 12:02
@Benjababe
Copy link
Contributor Author

Updated the UI, leaving the previous version above for reference

Replaces this

image

with

image

@robjob1938
Copy link

The work @Benjababe did looks perfect, thank you very much!

PikachuEXE
PikachuEXE previously approved these changes Aug 27, 2023
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can be removed like stated in #3938 (comment)

@@ -344,6 +344,7 @@ Settings:
Hide Active Subscriptions: Hide Active Subscriptions
Hide Video Description: Hide Video Description
Hide Comments: Hide Comments
Hide Comment Photos: Hide Comment Photos

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this naming. Maybe something like Hide Profile Pictures in Comments but i like to hear the other team members on this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Hide Comment Profile Pictures" or "Hide Comment Author Thumbnails" would be my top two suggestions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Hide Profile Pictures in Comments"
"Hide Comment Profile Pictures" looks more confusing ("Comment Profile Pictures" is too much to parse

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've changed my mind, that does sound better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opinions needed

auto-merge was automatically disabled August 28, 2023 23:42

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 28, 2023 23:43
auto-merge was automatically disabled August 29, 2023 07:34

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 29, 2023 07:34
Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreeTubeBot FreeTubeBot merged commit 0b44548 into FreeTubeApp:development Aug 30, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Option to hide Comment Photos
6 participants