Eliminate xblock liveness for shifts #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssarosenzweig
force-pushed
the
ra/shifts-rework
branch
from
78b3bcb to
5b5228a
Compare
20 tasks
alyssarosenzweig
force-pushed
the
ra/shifts-rework
branch
2 times, most recently
from
ecd29a5 to
6457d45
Compare
alyssarosenzweig
force-pushed
the
ra/shifts-rework
branch
from
6457d45 to
9cd6ebb
Compare
|
This PR causes Steam to crash early. Will need to bisect to find out why. |
alyssarosenzweig
force-pushed
the
ra/shifts-rework
branch
3 times, most recently
from
d3daec5 to
4147e95
Compare
I've split the PR up into atomic commits that are as small as is reasonable. I don't think I fixed whatever the bug is (and I did audit instcountci without finding any fault), but this should make the bisect results much more useful. |
|
Looks like the first commit that breaks Steam is |
alyssarosenzweig
force-pushed
the
ra/shifts-rework
branch
2 times, most recently
from
d6e7edd to
0a2f391
Compare
|
With latest changes this still crashes. First commit breaking steam is still |
alyssarosenzweig
force-pushed
the
ra/shifts-rework
branch
2 times, most recently
from
3ca5570 to
75216fa
Compare
This is something the new shift flag code will do. Backporting the opt since that's stalled and this reduces the diff. Signed-off-by: Alyssa Rosenzweig <[email protected]>
otherwise we might have the wrong input NZCV. Signed-off-by: Alyssa Rosenzweig <[email protected]>
this failed on an earlier version of the series that otherwise passed ci. Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
we'll hit this with _ShiftFlags. Signed-off-by: Alyssa Rosenzweig <[email protected]>
Generates flags for a variable shift as a dedicated IR op. This lets us optimize around it (without generating control flow, relying on deferred flag infra, etc). And it neatly solves our RA problem for shifts. Signed-off-by: Alyssa Rosenzweig <[email protected]>
all the variable shift impls need to do this dance, make it common. Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
force-pushed
the
ra/shifts-rework
branch
from
bfd9b34 to
b54d493
Compare
Sonicadvance1
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last one~