Validate that we have no crossblock liveness #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssarosenzweig
force-pushed
the
ra/validate
branch
from
ab34771 to
86558a4
Compare
alyssarosenzweig
changed the title
20 tasks
alyssarosenzweig
force-pushed
the
ra/validate
branch
from
86558a4 to
336e571
Compare
this ensures we put the StoreNZCV in the right block, which will fix validation fails later in the series. Signed-off-by: Alyssa Rosenzweig <[email protected]>
didn't fix this hard enough before. caught by validation. Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Now that we have successfully eliminated crossblock liveness from the IR we generate, validate as much to ensure it doesn't come back. We will take advantage of this new invariant in RA in the future. Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
force-pushed
the
ra/validate
branch
from
336e571 to
063954c
Compare
Sonicadvance1
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3548 obviously.
Now that we no longer have cross-block liveness anywhere, we should validate this invariant so it stays true. We'll take advantage of this for the new RA. This validation encountered a few places where cross-block liveness slipped thru the tracks, the first few patches here fix them.
This probably needs real games testing with ASSERTION_ENABLED.