Fix cursor appears in front of digit when highlighting amount and entering digit

[bernhardoj]

Details

The selection is updated manually and from the onSelectionChange event which could gives a wrong value.

Fixed Issues

$ #41762
PROPOSAL: #41762 (comment)

Tests

Same as QA Steps

• Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

1. Open a split bill page
2. Enter any amount
3. Select any user
4. Select all digits on any participant split amount input and replace it with any number
5. Verify the selection is at the right of the amount

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-14.at.22.10.25.mov

Android: mWeb Chrome

Screen.Recording.2024-05-14.at.22.12.36.mov

iOS: Native

Screen.Recording.2024-05-14.at.22.06.10.mov

iOS: mWeb Safari

Screen.Recording.2024-05-14.at.22.08.07.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-14.at.22.06.47.mov

MacOS: Desktop

Screen.Recording.2024-05-14.at.22.07.16.mov

[melvin-bot]

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[jayeshmangwani]

@bernhardoj I am getting some inconsistencies between staging and this PR on the web. If we try to double-click on the input value, it selects all the values on staging, but in our PR, double-clicking does nothing. Please confirm whether you are getting the same results.

Also, when I try to press between the input values on the web, selection doesn't go to that value. e.g. if input values is 789, we press on 1st index then cursor should be at the 8.

selection-bug.mov

[bernhardoj]

@jayeshmangwani I can reproduce it in main too. Most likely happen after it's migrated to selection list here.
#40785

[jayeshmangwani]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWeb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mWeb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[jayeshmangwani]

LGTM 🚀

[youssef-lr]

@bernhardoj On iOS if I tap to the left of the first digit of an amount, the selection properly is moved to the left, however if I press delete it goes to the beginning. I don't know if this is reproducible in Android.

RPReplay_Final1715795745.MP4

[bernhardoj]

Hmm, I can't reproduce it. I have merged with main, idk if that helps.

Screen.Recording.2024-05-16.at.13.35.54.mov

Btw, looks like the split calculation is broken. I enter the amount as 25 but both participant split is also 25 instead of 12.5 can't reproduce it anymore, idk what step I took that cause this issue before I can repro it again on web, really weird

[youssef-lr]

Btw, looks like the split calculation is broken. I enter the amount as 25 but both participant split is also 25 instead of 12.5 can't reproduce it anymore, idk what step I took that cause this issue before I can repro it again on web, really weird

I'm not able to reproduce this one

[youssef-lr]

Hmm, I can't reproduce it. I have merged with main, idk if that helps.

@bernhardoj You have to put the cursor in the beginning of the amount, not the end, so in your recording try to tap next to the left of the digit 2

[bernhardoj]

@youssef-lr Oh, I see you put it on the end in your video, so I follow it 😂, but I am still unable to reproduce it.

Untitled.mov

[jayeshmangwani]

I am also not able to reproduce this issue.

iOS-cursor.mov

[youssef-lr]

Testing again shortly

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42158/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42158/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42158/NewExpensify.dmg	https://42158.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[youssef-lr]

I'm still able to reproduce :/ I tap exactly to the left of the first digit

RPReplay_Final1716205090.MP4

[youssef-lr]

Or you can also tap on the currency

[bernhardoj]

Hmm, still can't reproduce it. In your video, when you tap the currency, the selection moves to the right, that's why when you press delete, the rightmost digit is removed. Maybe it's reproducible in physical devices only? I don't have a physical iOS device.

Btw, have you checked whether it's reproducible in main too?

[jayeshmangwani]

I have tested the Android ad-hoc, and the issue is not happening for me; my device is not added to iOS testing, so I can not confirm in iOS adhoc

[youssef-lr]

Hmm, still can't reproduce it. In your video, when you tap the currency, the selection moves to the right, that's why when you press delete, the rightmost digit is removed

Yes that works as expected, but the selection should remain at the end, no?

[bernhardoj]

Yeah, I would expect it to remain at the end too, but I think the real problem here is this one,

when you tap the currency, the selection moves to the right,

My guess is that the selection state of the component

App/src/components/MoneyRequestAmountInput.tsx

Lines 120 to 123 in e8ae3c5

	const [selection, setSelection] = useState({
	start: selectedAmountAsString.length,
	end: selectedAmountAsString.length,
	});

doesn't match the TextInput internal native selection. So, the (MoneyRequestAmountInput)selection state is still at the left (correct one), but the TextInput internal selection is at the right (wrong one), and when we update the value, it makes sense for the cursor to "move" to the left because the prevSelection state is at the left.

App/src/components/MoneyRequestAmountInput.tsx

Line 154 in e8ae3c5

setSelection((prevSelection) => getNewSelection(prevSelection, isForwardDelete ? strippedAmount.length : prevAmount.length, strippedAmount.length));

Maybe it's related to this comment

App/src/components/Composer/index.native.tsx

Lines 27 to 28 in e8ae3c5

	// On Android the selection prop is required on the TextInput but this prop has issues on IOS
	selection,

I think we should just apply this fix for Android? Or all except iOS?

[youssef-lr]

Making another build to test

[youssef-lr]

@bernhardoj can you please merge with main?

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42158/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42158/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42158/NewExpensify.dmg	https://42158.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[bernhardoj]

Merged with main

[jayeshmangwani]

@youssef-lr Is it possible to add my iOS device for ad-hoc testing builds? I can reproduce the original issue on my iOS device in app store build. To verify this PR ad-hoc, my UDID needs to be added for testing

[jayeshmangwani]

Is it possible to add my iOS device for ad-hoc testing builds? I can reproduce the original issue on my iOS device in app store build. To verify this PR ad-hoc, my UDID needs to be added for testing

@youssef-lr Tested in latest app store build and issue is not happening for me now(it was happening for me on the previous version), can you please check on your side if issue is still happening for you ?

[youssef-lr]

Is it possible to add my iOS device for ad-hoc testing builds? I

@jayeshmangwani I'm not familiar with how this is done, but I'll ask for you.

Tested in latest app store build and issue is not happening for me now(it was happening for me on the previous version), can you please check on your side if issue is still happening for you ?

I just reproduced it in the latest build. I'm making a build right now of this PR to test again.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42158/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42158/NewExpensify.dmg	https://42158.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42158/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42158/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42158/NewExpensify.dmg	https://42158.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[youssef-lr]

I think we should just apply this fix for Android? Or all except iOS?

Can we try it in this PR? I'm still reproducing the issue on latest build

[bernhardoj]

Updated to only apply it on android

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42158/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42158/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42158/NewExpensify.dmg	https://42158.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[youssef-lr]

Yeah that fixed it!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.82-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[jayeshmangwani]

@bernhardoj I am confused why we removed the openReport call from here when I have approved the PR then this change was not here?

[bernhardoj]

Ah, my bad. It's from my lint commit here: 6d0630d

I think I accidentally committed it when working on this PR

[jayeshmangwani]

Oh, it is from another PR, but it was intentional to remove it, so there is no need to revert this change, right?

[bernhardoj]

Yes, it was intentional to remove it, so no need to revert.