[HOLD for payment 2024-11-11] iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.49.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Open the app and log in
2. Navigate to the group chat
3. Tap + > Split expense
4. Enter the amount and proceed to the confirmation page
5. Delete the participant's amount by tapping the delete key
6. Select the other participant's amount by double tapping and remove it
7. Start entering a new amount

Expected Result:

The cursor does not jump in front of the next digit

Actual Result:

The cursor jumps in front of the next digit after removing the 1st digit before decimal point (step 5) or when removing the amount and entering one digit (steps 6-7)

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6636079_1729054164475.IMG_0475.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Christinadobrzyn]

yes, looks like the cursor jumps in front of the last digit when deleting and entering a new amount. Asking if this might be related to #48869

[WojtekBoman]

Hey @Christinadobrzyn, I've investigated this issue and to me the reason is the same like in this. We have two methods to update selection in MoneyRequestAmountInput. There is a case when we update selection in setNewAmount, but we operate on a value that has been already updated in onSelectionChange. It can be fixed by blocking the update in onSelectionChange when calling setNewAmount. It has been already implemented for the Android platform (the variable shouldIgnoreSelectionWhenUpdatedManually). On the other hand maybe we should consider calling setSelection only from one method to make it more clear. Setting shouldIgnoreSelectionWhenUpdatedManually to true seems to work for iOS, but I realize there are a lot of issues with this component, so we should investigate this solution further to make sure other issues don't appear because of this.

[Christinadobrzyn]

Hi @WojtekBoman! Thank you for your thorough investigation. It sounds like this should be treated as a separate issue and will require some pretty deep investigation.

Would you want to take this job on after you're done with #48869 or do you think this needs to be resolved by an internal engineer?

[WojtekBoman]

I'll take care of that :) This one is already finished, I wrote a request to close it

[Christinadobrzyn]

Awesome! Thank you @WojtekBoman! Let us know how we can help!

[WojtekBoman]

I'm currently working on solving this issue, I believe I found the cause and I'm trying to fix it properly. When I release PR, I'll need help looking for possible regressions :)

[Christinadobrzyn]

PR in the works - #51306

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount #51306

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

@rayane-djouah @Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @WojtekBoman is from an agency-contributor and not due payment
• ROLE: @rayane-djouah paid $250 via Upwork (LINK)

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[rayane-djouah]

BugZero Checklist:

• Classify the bug:

  Bug classification

  Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

  Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

  Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Reusable and stylable money request amount input #40390 (comment)

• If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• @Christinadobrzyn Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/443775

Regression Test Proposal

#### Precondition:

- Create a group chat.

#### Test:

1. Navigate to the group chat.
2. Tap the '+' symbol, then select 'Split expense'.
3. Enter an amount and proceed to the confirmation page.
4. Delete a participant's amount by tapping the delete key.
5. Verify that the cursor does not jump during deletion.
6. Verify that the cursor does not jump in front of the next digit after removing the first digit before the decimal point.
7. Select another participant's amount by double tapping and remove it.
8. Begin entering a new amount.
9. Verify that the cursor does not jump when removing the amount and entering one digit.
10. Continue adding digits to the new amount.
11. Verify that the cursor does not jump in front of the next digit.

Do we agree 👍 or 👎

[Christinadobrzyn]

This one seems a little strange as the PR linked is from April - is there anything I should know about paying this? Were there regressions?

Payment summary is here - #50886 (comment) @rayane-djouah can you accept the Upwork offer?

[rayane-djouah]

@Christinadobrzyn - Offer accepted, thanks!

[mountiny]

I think we can pay for the review of #51306 and close

[Christinadobrzyn]

Thanks @mountiny and @rayane-djouah!

Regression test - https://github.com/Expensify/Expensify/issues/443775

Paid out based on this payment summary

closing!