Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cursor appears in front of digit when highlighting amount and entering digit #42158

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Fix cursor appears in front of digit when highlighting amount and entering digit #42158

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2263ee9
fix wrong selection after replacing all values
bernhardoj May 14, 2024
f0a8ec1
Merge branch 'main' into fix/41762-wrong-selection-value-after-replac…
bernhardoj May 15, 2024
b4c51c3
Merge branch 'main' into fix/41762-wrong-selection-value-after-replac…
bernhardoj May 16, 2024
6a25247
Merge branch 'main' into fix/41762-wrong-selection-value-after-replac…
bernhardoj May 30, 2024
768abc5
Merge branch 'main' into fix/41762-wrong-selection-value-after-replac…
bernhardoj Jun 6, 2024
bb939a6
Merge branch 'main' into fix/41762-wrong-selection-value-after-replac…
bernhardoj Jun 7, 2024
7481eb3
only apply the fix for android
bernhardoj Jun 7, 2024
6d0630d
lint
bernhardoj Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libs/actions/Report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,6 @@ function navigateToAndOpenReportWithAccountIDs(participantAccountIDs: number[])
*/
function navigateToAndOpenChildReport(childReportID = '0', parentReportAction: Partial<ReportAction> = {}, parentReportID = '0') {
if (childReportID !== '0') {
openReport(childReportID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernhardoj I am confused why we removed the openReport call from here when I have approved the PR then this change was not here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad. It's from my lint commit here: 6d0630d

I think I accidentally committed it when working on this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it is from another PR, but it was intentional to remove it, so there is no need to revert this change, right?

Copy link
Contributor Author

@bernhardoj bernhardoj Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was intentional to remove it, so no need to revert.

Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(childReportID));
} else {
const participantAccountIDs = [...new Set([currentUserAccountID, Number(parentReportAction.actorAccountID)])];
Expand Down
2 changes: 1 addition & 1 deletion src/libs/shouldIgnoreSelectionWhenUpdatedManually/index.android.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type ShouldIgnoreSelectionWhenUpdatedManually from './types.ts';
import type ShouldIgnoreSelectionWhenUpdatedManually from './types';

const shouldIgnoreSelectionWhenUpdatedManually: ShouldIgnoreSelectionWhenUpdatedManually = true;

Expand Down
2 changes: 1 addition & 1 deletion src/libs/shouldIgnoreSelectionWhenUpdatedManually/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type ShouldIgnoreSelectionWhenUpdatedManually from './types.ts';
import type ShouldIgnoreSelectionWhenUpdatedManually from './types';

const shouldIgnoreSelectionWhenUpdatedManually: ShouldIgnoreSelectionWhenUpdatedManually = false;

Expand Down
Loading