fix: [Violations] Distance - Incorrect error message when distance amount is changed to smaller amount. #41649

Krishna2323 · 2024-05-04T23:04:07Z

Details

Fixed Issues

$ #41401
PROPOSAL: #41401 (comment)

Tests

Go to Submit expense > Scan > Add valid receipt > Select workspace > Submit
Wait for scanning to complete, once completed edit the amount to a higher value
Verify Amount greater than scanned receipt error appears below amount field
Go to Submit expense > Distance > Select 2 waypoints > Select workspace > Submit
Open transaction page > Wait for amount to be calculated > Edit the amount to higher value
Verify Amount differs from calculated distance error appears below amount field

Verify that no errors appear in the JS console

Offline tests

Go to Submit expense > Scan > Add valid receipt > Select workspace > Submit
Wait for scanning to complete, once completed edit the amount to a higher value
Verify Amount greater than scanned receipt error appears below amount field
Go to Submit expense > Distance > Select 2 waypoints > Select workspace > Submit
Open transaction page > Wait for amount to be calculated > Edit the amount to higher value
Verify Amount differs from calculated distance error appears below amount field

QA Steps

Go to Submit expense > Scan > Add valid receipt > Select workspace > Submit
Wait for scanning to complete, once completed edit the amount to a higher value
Verify Amount greater than scanned receipt error appears below amount field
Go to Submit expense > Distance > Select 2 waypoints > Select workspace > Submit
Open transaction page > Wait for amount to be calculated > Edit the amount to higher value
Verify Amount differs from calculated distance error appears below amount field

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ount is changed to smaller amount. Signed-off-by: Krishna Gupta <[email protected]>

melvin-bot · 2024-05-04T23:04:12Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-05-04T23:53:52Z

@JmillsExpensify @sobitneupane, I found one more issue in this PR. We only show the Receipt Verified audit, but when we have violation notices, we don't show the 'Issue/Issues found' text. The reason for that is I misunderstood this comment and hid the 'Issue/Issues found' message along with Receipt Verified message until the receipt status is SCANCOMPLETE but in case of issue while scanning, the receipt status is to OPEN.

I have fixed the above issue, now it will show Issue/Issues found if we have receipt violations and receipt is present.

Yes we shouldn't show the taxRateChanged note on NewDot, as it is being deprecated given that we have implemented that feature differently vs OldDot.

One more question on the above comment: do we also need to remove the taxAmountChanged notice, along with taxRateChanged, from NewDot?

App/src/CONST.ts

Line 3622 in 550e83b

TAX_AMOUNT_CHANGED: 'taxAmountChanged',

App/src/CONST.ts

Line 3624 in 550e83b

TAX_RATE_CHANGED: 'taxRateChanged',

Bug

Monosnap (149) New Expensify 2024-05-05 05-09-31

sobitneupane

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-07.at.14.22.47.mov

MacOS: Desktop

sobitneupane · 2024-05-07T09:04:46Z

@Krishna2323 Have we considered different types as mentioned here? Can you please complete the PR Author checklist. Please include the test cases for different types.

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-05-10T10:03:33Z

One more question on the above comment: do we also need to remove the taxAmountChanged notice, along with taxRateChanged, from NewDot?

@JmillsExpensify bump on the question.

Krishna2323 · 2024-05-10T10:05:43Z

Have we considered different types as mentioned #41401 (comment)?

Code has been updated according to this, will update test cases and recordings after getting clarification on the question above.

JmillsExpensify · 2024-05-14T03:52:00Z

Whoops, sorry missed this.

One more question on the above comment: do we also need to remove the taxAmountChanged notice, along with taxRateChanged, from NewDot?

Yes, that's correct. We aren't going to show these on NewDot, as both will generate system messages when changed. We also show what tax rate is "default" in a parallel initiative that's currently in implementation for track tracking in New Expensify.

JmillsExpensify · 2024-05-15T15:17:53Z

Just confirming that the above response makes sense?

Krishna2323 · 2024-05-17T07:32:34Z

@JmillsExpensify, yup thats clear to me, updating the PR in few moments.

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-05-17T08:29:57Z

@sobitneupane, you can review the code changes now. However, I'm not sure what to add in the test cases. Could you provide some guidance? Several types of amount notices are there.

sobitneupane · 2024-05-20T06:51:17Z

However, I'm not sure what to add in the test cases. Could you provide some guidance? Several types of amount notices are there.

@Krishna2323 You can include the test cases based on this expected output.

Verify that the notice violations related to Amount is shown below the amount field and other notice violations like date below the specific field(#41401 (comment)).

Let's show all these cases under the amount field, since a) we think it's more impactful/intuitive to highlight that the amount is greater than the receipt, than the other way around; and b) the field you need to take action on in order to fix the violation is the amount field, not the receipt field

Verify notice violations based on their type

{data: {type: 'distance'}}
{data: {type: 'card'}}
{data: {type: 'smartscan'}}
{data: {type: 'smartscan', displayPercentVariance: $displayPercentVariance}}

You can also include Tests for the bug you discussed here.

Basically, the tests should cover the changes made in the PR. You can add multiple set of test cases.

sobitneupane · 2024-05-20T07:16:19Z

In distance request, I can still see the wrong error message.

Krishna2323 · 2024-05-20T07:53:52Z

In distance request, I can still see the wrong error message.

I guess this requires backend change, @cead22 can you pls confirm?

JmillsExpensify · 2024-05-20T15:07:29Z

I think you mean @cead22

Krishna2323 · 2024-05-20T15:56:01Z

I think you mean @cead22

yeah 🥶

cead22 · 2024-05-21T02:12:23Z

Yes, I'll get the PR for that submitted tomorrow

cead22 · 2024-05-21T21:33:28Z

I submitted the PR for review

Krishna2323 · 2024-05-30T23:36:18Z

@cead22, any update on the backend PR?

cead22 · 2024-05-31T00:01:14Z

Yeah it's live as of yesterday morning (PT)

Krishna2323 · 2024-07-05T22:42:48Z

@sobitneupane, can you pls review again? all requested changes are done.

sobitneupane · 2024-07-08T09:09:10Z

@Krishna2323 The violation message are being shown below the Receipt instead of respective field.

cead22 · 2024-07-08T16:31:50Z

@Krishna2323 The violation message are being shown below the Receipt instead of respective field.

That means we might not be using violationFields or the flow that uses violationFields to get the mapping of violation -> field to show violation

src/components/ReceiptAudit.tsx

src/components/ReportActionItem/MoneyRequestView.tsx

src/hooks/useViolations.ts

cead22 · 2024-07-08T18:42:35Z

@Krishna2323 please put this at the top of your priority list so we can merge this this week (ideally today/tomorrow)

Krishna2323 · 2024-07-08T21:01:02Z

Will start working on the suggestions in a hour.

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-07-08T22:30:22Z

src/components/ReportActionItem/MoneyRequestView.tsx

@@ -340,14 +340,13 @@ function MoneyRequestView({
    const receiptViolationNames: OnyxTypes.ViolationName[] = [
        CONST.VIOLATIONS.RECEIPT_REQUIRED,
        CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED,
-        CONST.VIOLATIONS.MODIFIED_DATE,


@sobitneupane @cead22, I mistakenly added modified amount violation here while resolving conflict, thats why the violation was shown under receipt. I have removed that and also CONST.VIOLATIONS.MODIFIED_DATE because I believe the date violation should also be shown under date field.

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-07-08T23:24:15Z

@sobitneupane @cead22, can you pls check again, I have tested this.

cead22 · 2024-07-09T00:54:46Z

@Krishna2323 what about #41649 (comment) ?

sobitneupane · 2024-07-09T07:06:24Z

@Krishna2323 Please make sure to test the PR in your end after each change.

Krishna2323 · 2024-07-09T11:40:01Z

@sobitneupane, tested again 😵‍💫

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-07-12T21:45:44Z

src/components/ReportActionItem/MoneyRequestView.tsx

+    // Whether to show receipt audit result (e.g.`Verified`, `Issue Found`) and messages (e.g. `Receipt not verified. Please confirm accuracy.`)
+    // `!!(receiptViolations.length || didReceiptScanSucceed)` is for not showing `Verified` when `receiptViolations` is empty and `didReceiptScanSucceed` is false.
+    const shouldShowAuditMessage =
+        !isReceiptBeingScanned && hasReceipt && !!(receiptViolations.length || didReceiptScanSucceed) && !!canUseViolations && ReportUtils.isPaidGroupPolicy(report);


@sobitneupane @cead22, updated shouldShowAuditMessage, now this is will be enough for handling violation messages and audit result both. It works correctly as per my testing.

OSBotify · 2024-07-15T15:56:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:03:35Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:12:19Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:17:28Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:48:47Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: [Violations] Distance - Incorrect error message when distance am…

2f4d561

…ount is changed to smaller amount. Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 requested a review from a team as a code owner May 4, 2024 23:04

melvin-bot bot requested review from sobitneupane and removed request for a team May 4, 2024 23:04

Krishna2323 added 2 commits May 5, 2024 04:41

remove tax rate changed violation.

bac54f1

Signed-off-by: Krishna Gupta <[email protected]>

remove ReceiptAuditHeader.

d399453

Signed-off-by: Krishna Gupta <[email protected]>

sobitneupane reviewed May 7, 2024

View reviewed changes

Krishna2323 added 3 commits May 10, 2024 14:43

Merge branch 'Expensify:main' into krishna2323/issue/41401

c7ec1df

updated amountModified translation.

34d5e2e

Signed-off-by: Krishna Gupta <[email protected]>

minor update.

0549056

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 added 2 commits May 17, 2024 13:03

Merge branch 'Expensify:main' into krishna2323/issue/41401

ef8e655

remove taxAmountChanged & taxRateChanged notice violations.

f039038

Signed-off-by: Krishna Gupta <[email protected]>

cead22 requested changes Jul 8, 2024

View reviewed changes

src/components/ReceiptAudit.tsx Outdated Show resolved Hide resolved

src/components/ReportActionItem/MoneyRequestView.tsx Outdated Show resolved Hide resolved

src/hooks/useViolations.ts Outdated Show resolved Hide resolved

Krishna2323 added 4 commits July 9, 2024 02:31

Merge branch 'Expensify:main' into krishna2323/issue/41401

4fe1913

update comments.

68ebaa7

Signed-off-by: krishna2323 <[email protected]>

minor update.

2a76377

Signed-off-by: krishna2323 <[email protected]>

fix: amount violation shows under receipt.

c5d5a3c

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 commented Jul 8, 2024

View reviewed changes

fix amount violation not showing.

995eaed

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 added 4 commits July 10, 2024 19:51

remove shouldShowAuditSuccess & shouldShowAuditFailure prop.

e3b692e

Signed-off-by: krishna2323 <[email protected]>

add shouldShowAuditResult prop in ReceiptAudit.

0a92c99

Signed-off-by: krishna2323 <[email protected]>

refactor.

1c4d2a1

Signed-off-by: krishna2323 <[email protected]>

add comment.

7cdc36c

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 commented Jul 12, 2024

View reviewed changes

cead22 approved these changes Jul 15, 2024

View reviewed changes

cead22 merged commit fc1d3d7 into Expensify:main Jul 15, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

melvin-bot bot mentioned this pull request Jul 17, 2024

[PAID] [$250] [Violations] Distance - Incorrect error message when distance amount is changed to smaller amount #41401

Closed

6 tasks

fix: [Violations] Distance - Incorrect error message when distance amount is changed to smaller amount. #41649

fix: [Violations] Distance - Incorrect error message when distance amount is changed to smaller amount. #41649

Conversation

Krishna2323 commented May 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 4, 2024

Krishna2323 commented May 4, 2024 • edited Loading

Bug

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane commented May 7, 2024 • edited Loading

Krishna2323 commented May 10, 2024

Krishna2323 commented May 10, 2024

JmillsExpensify commented May 14, 2024

JmillsExpensify commented May 15, 2024

Krishna2323 commented May 17, 2024

Krishna2323 commented May 17, 2024 • edited Loading

sobitneupane commented May 20, 2024 • edited Loading

sobitneupane commented May 20, 2024

Krishna2323 commented May 20, 2024 • edited Loading

JmillsExpensify commented May 20, 2024

Krishna2323 commented May 20, 2024

cead22 commented May 21, 2024 • edited Loading

cead22 commented May 21, 2024

Krishna2323 commented May 30, 2024

cead22 commented May 31, 2024 • edited Loading

Krishna2323 commented Jul 5, 2024

sobitneupane commented Jul 8, 2024

cead22 commented Jul 8, 2024

cead22 commented Jul 8, 2024

Krishna2323 commented Jul 8, 2024

Krishna2323 Jul 8, 2024 • edited Loading

Choose a reason for hiding this comment

Krishna2323 commented Jul 8, 2024

cead22 commented Jul 9, 2024

sobitneupane commented Jul 9, 2024

Krishna2323 commented Jul 9, 2024

Krishna2323 Jul 12, 2024 • edited Loading

Choose a reason for hiding this comment

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

Krishna2323 commented May 4, 2024 •

edited

Loading

Krishna2323 commented May 4, 2024 •

edited

Loading

sobitneupane left a comment •

edited

Loading

sobitneupane commented May 7, 2024 •

edited

Loading

Krishna2323 commented May 17, 2024 •

edited

Loading

sobitneupane commented May 20, 2024 •

edited

Loading

Krishna2323 commented May 20, 2024 •

edited

Loading

cead22 commented May 21, 2024 •

edited

Loading

cead22 commented May 31, 2024 •

edited

Loading

Krishna2323 Jul 8, 2024 •

edited

Loading

Krishna2323 Jul 12, 2024 •

edited

Loading