Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Violations] Distance - Incorrect error message when distance amount is changed to smaller amount. #41649

Merged
merged 43 commits into from
Jul 15, 2024
Merged

fix: [Violations] Distance - Incorrect error message when distance amount is changed to smaller amount. #41649

merged 43 commits into from
Jul 15, 2024

Commits on May 4, 2024

  1. fix: [Violations] Distance - Incorrect error message when distance am… 

    …ount is changed to smaller amount.

Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    2f4d561 View commit details
    Browse the repository at this point in the history

  2. remove tax rate changed violation. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    bac54f1 View commit details
    Browse the repository at this point in the history

  3. remove ReceiptAuditHeader. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    d399453 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored May 10, 2024
    Configuration menu
    Copy the full SHA
    c7ec1df View commit details
    Browse the repository at this point in the history

  2. updated amountModified translation. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    34d5e2e View commit details
    Browse the repository at this point in the history

  3. minor update. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0549056 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored May 17, 2024
    Configuration menu
    Copy the full SHA
    ef8e655 View commit details
    Browse the repository at this point in the history

  2. remove taxAmountChanged & taxRateChanged notice violations. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f039038 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. fix conflicts. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    be4f9be View commit details
    Browse the repository at this point in the history

  2. fix conflicts. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    c9fd9aa View commit details
    Browse the repository at this point in the history

  3. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored Jun 2, 2024
    Configuration menu
    Copy the full SHA
    b801997 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'krishna2323/issue/41401' of https://github.com/Krishna2… 

    …323/App into krishna2323/issue/41401
    @Krishna2323
    Krishna2323 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    4240c2f View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1043d16 View commit details
    Browse the repository at this point in the history

  2. use violation data type from backend. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3c71e67 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. add ViolationMessages for receipt. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    12f0433 View commit details
    Browse the repository at this point in the history

  2. return all type of violations for paid policies. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    407e552 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. fix: merge conflicts. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7611122 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    4ebb250 View commit details
    Browse the repository at this point in the history

  3. add changes back in MoneyRequestView. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    03a9345 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'krishna2323/issue/41401' of https://github.com/Krishna2… 

    …323/App into krishna2323/issue/41401
    @Krishna2323
    Krishna2323 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d693489 View commit details
    Browse the repository at this point in the history

  5. updated receiptViolationNames. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    245d667 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    efd639c View commit details
    Browse the repository at this point in the history

  2. fix type check. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    4e8f365 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. minor fixes. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9e452c4 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    49954fb View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Merge branch 'main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored Jun 23, 2024
    Configuration menu
    Copy the full SHA
    d671670 View commit details
    Browse the repository at this point in the history

  2. fix lint issue. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    e2851c4 View commit details
    Browse the repository at this point in the history

  3. get displayPercentVariance from violation data. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    7ae2d6b View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e5420c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7c38e5c View commit details
    Browse the repository at this point in the history

  2. minor fixes. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1595f33 View commit details
    Browse the repository at this point in the history

  3. update isPaidGroupPolicy param to shouldShowOnlyViolations. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    2589ba6 View commit details
    Browse the repository at this point in the history

  4. add ReceiptAuditMessages back. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6e63f57 View commit details
    Browse the repository at this point in the history

  5. add comments. 

    Signed-off-by: Krishna Gupta <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9fec7f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'Expensify:main' into krishna2323/issue/41401

    @Krishna2323
    Krishna2323 authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4fe1913 View commit details
    Browse the repository at this point in the history

  2. update comments. 

    Signed-off-by: krishna2323 <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    68ebaa7 View commit details
    Browse the repository at this point in the history

  3. minor update. 

    Signed-off-by: krishna2323 <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2a76377 View commit details
    Browse the repository at this point in the history

  4. fix: amount violation shows under receipt. 

    Signed-off-by: krishna2323 <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c5d5a3c View commit details
    Browse the repository at this point in the history

  5. fix amount violation not showing. 

    Signed-off-by: krishna2323 <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    995eaed View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. remove shouldShowAuditSuccess & shouldShowAuditFailure prop. 

    Signed-off-by: krishna2323 <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e3b692e View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. add shouldShowAuditResult prop in ReceiptAudit. 

    Signed-off-by: krishna2323 <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0a92c99 View commit details
    Browse the repository at this point in the history

  2. refactor. 

    Signed-off-by: krishna2323 <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1c4d2a1 View commit details
    Browse the repository at this point in the history

  3. add comment. 

    Signed-off-by: krishna2323 <[email protected]>
    @Krishna2323
    Krishna2323 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7cdc36c View commit details
    Browse the repository at this point in the history