-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow detaching receipts from transactions #26219
Conversation
Can't merge till web-e PR (https://github.com/Expensify/Web-Expensify/pull/38613) gets to prod, but can start testing very soon! |
Frick, we need Auth changes for this too (https://github.com/Expensify/Auth/pull/8620) - & even more web-e changes So I'm de-prioritizing this for a week ish |
I think you can fix the issue by moving these modals inside this closing Modal tag |
I pushed a commit with the fix since Alberto is ooo. @mananjadhav wanna retest and re-review? @Beamanator can you also review since the last commit is now mine? |
Just took the pull and testing again. |
@luacmartins Thanks for fixing this. I've completed the checklist. I've updated the iOS screencast and also retested on Web and Android to check if it caused any other issue. All good here. 🎀 👀 🎀 C+ reviewed. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was associated with a deploy blocker #29452, I'm going to revert it so @Beamanator can fix those issues at his own pace. |
We're not reverting this, we'll work on a fix instead |
Hey everyone, I'm managing the payment GH issue for @mananjadhav's PR review and wanted to check in on what's going on. It looks like this PR caused a deploy blocker, and now you'll be working on a fix to resolve that issue. Should I wait until that fix is complete before completing any payments? |
@sakluger Yes it had a regression. The fix was deployed to staging, but will wait for fix to go live before we can proceed for payment. |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
2 similar comments
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
Thanks! |
@mananjadhav thanks for clarifying! Looks like it was deployed to staging on Friday, I can set a payment date now. |
title={translate('receipt.deleteReceipt')} | ||
isVisible={isDeleteReceiptConfirmModalVisible} | ||
onConfirm={deleteAndCloseModal} | ||
onCancel={closeConfirmModal} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, if there are 2 Modals in a screen, we have to handle onClose
callback on each Modal properly #31256 (comment). Otherwise, it will cause an issue here #30045
To be tested with https://github.com/Expensify/Web-Expensify/pull/39018
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/295255
Tests
Currently for testing, you need this Auth PR: https://github.com/Expensify/Auth/pull/8620
scanReceipts
beta (or you have 'all' betas enabled)...
in the upper-right corner. There should be no "Remove" option:expensiworks
or manually adding an amount.Delete
:...
. Confirm you can now add a receipt:Offline tests
Make sure we optimistically, correctly show that the receipt has been removed
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android