[HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$125] Attachment - Modal error does not appear after uploading an attachment larger then 24MB #29452

lanitochka17 · 2023-10-12T14:44:00Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/
Log in with any Gmail account
Navigate to a chat
Click on the + button in the compose box and upload an attachment that is larger than the 24 MB limit

Expected Result:

The error modal appears immediately upon upload

Actual Result:

Nothing happened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Windows: Chrome

Bug6234395_1697114926610.24_MB_limit.mp4

Video with Production:

Recording.6377.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01745a035d1d92bb33
Upwork Job ID: 1712522747811811328
Last Price Increase: 2023-10-12
Automatic offers:

ishpaul777 | Contributor | 27169589

melvin-bot · 2023-10-12T14:44:06Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-12T14:44:08Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-12T17:36:57Z

Job added to Upwork: https://www.upwork.com/jobs/~01745a035d1d92bb33

melvin-bot · 2023-10-12T17:37:03Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

melvin-bot · 2023-10-12T17:37:09Z

Upwork job price has been updated to $125

ishpaul777 · 2023-10-12T17:58:54Z

Proposal

Problem

Attachment - Modal error does not appear after uploading an attachment larger then 24MB

Root Cause

offending PR- #26219
We have nested the ConfirmModal inside the AttachmentModal so it only becomes visible when Attachmentmodal is visible.
https://github.com/Expensify/App/blob/3b98327273d361b2afd3617f93ca2718ab0aaf61/src/components/AttachmentModal.js

Changes

We need to move the ConfirmModal (for FIle validation) outside of attachment modal.
We can leave attachment reciept modal inside the modal so the it works as expected on Ios. #26219 (comment)

            // rest of code in https://github.com/Expensify/App/blob/3b98327273d361b2afd3617f93ca2718ab0aaf61/src/components/AttachmentModal.js
            {isAttachmentReceipt && (
                    <ConfirmModal
                        title={translate('receipt.deleteReceipt')}
                        isVisible={isDeleteReceiptConfirmModalVisible}
                        onConfirm={deleteAndCloseModal}
                        onCancel={closeConfirmModal}
                        prompt={translate('receipt.deleteConfirmation')}
                        confirmText={translate('common.delete')}
                        cancelText={translate('common.cancel')}
                        danger
                    />
                )}
            </Modal>
            <ConfirmModal
                title={attachmentInvalidReasonTitle ? translate(attachmentInvalidReasonTitle) : ''}
                onConfirm={closeConfirmModal}
                onCancel={closeConfirmModal}
                isVisible={isAttachmentInvalid}
                prompt={attachmentInvalidReason ? translate(attachmentInvalidReason) : ''}
                confirmText={translate('common.close')}
                shouldShowCancelButton={false}
            />

luacmartins · 2023-10-12T23:06:49Z

@ishpaul777 are you able to work on a PR now?

ishpaul777 · 2023-10-12T23:12:24Z

yes I am available for few hours

melvin-bot · 2023-10-12T23:13:46Z

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($125)

luacmartins · 2023-10-12T23:13:46Z

Cool, it's all yours!

melvin-bot · 2023-10-12T23:13:50Z

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-12T23:56:51Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

jasperhuangg · 2023-10-13T00:33:23Z

@ishpaul777 any updates on that PR?

ishpaul777 · 2023-10-13T00:34:37Z

android build is taking too much time I am done with testing on all other platforms.

melvin-bot · 2023-10-16T21:52:37Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] fixes: invalid file modal and delete option shown for setted IOU #29524

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@sobitneupane does not require payment (Eligible for Manual Requests)
@ishpaul777 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:52:39Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@luacmartins] The PR that introduced the bug has been identified. Link to the PR: Allow detaching receipts from transactions #26219
[@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Allow detaching receipts from transactions #26219 (comment)
[@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@sobitneupane / @ishpaul777] Determine if we should create a regression test for this bug.
[@sobitneupane / @ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

joekaufmanexpensify · 2023-10-20T12:45:39Z

@sobitneupane mind taking care of the BZ checklist here when you're back next week?

joekaufmanexpensify · 2023-10-23T13:29:57Z

Not overdue

ishpaul777 · 2023-10-23T13:34:53Z

@joekaufmanexpensify I believe this is due for payment, isn't it ?

joekaufmanexpensify · 2023-10-23T13:38:34Z

Yep! The BZ checklist just needs to be complete before we can issue payment.

ishpaul777 · 2023-10-23T13:41:39Z

okay! got it Thanks!

joekaufmanexpensify · 2023-10-24T20:19:58Z

Bumped in Slack

joekaufmanexpensify · 2023-10-25T14:09:34Z

Still pending BZ checklist

joekaufmanexpensify · 2023-10-26T14:29:06Z

@sobitneupane will you be able to complete this this week?

melvin-bot · 2023-10-30T12:53:25Z

@luacmartins, @sobitneupane, @joekaufmanexpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

sobitneupane · 2023-10-30T13:25:55Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

The PR that introduced the bug has been identified. Link to the PR:

#26219

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#26219 (comment)

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Determine if we should create a regression test for this bug.

I don't think regression test will be required for this specific bug. I do believe that we already have regression test for such cases.

joekaufmanexpensify · 2023-10-30T13:48:46Z

Great, ty! I will finish this up today.

joekaufmanexpensify · 2023-10-30T14:43:49Z

All set to issue payment. This one qualifies for speed bonus, so we need to issue the following payments:

@ishpaul777 - $187.50 ($125 for PR, and $62.50 for speed bonus). Paid via upwork.
@sobitneupane - $187.50 ($125 for C+ and $62.50 for speed bonus). Paid via NewDot.
Reported internally, so no reporting payment.

joekaufmanexpensify · 2023-10-30T14:45:18Z

@ishpaul777 $187.50 sent and contract ended!

joekaufmanexpensify · 2023-10-30T14:45:46Z

@sobitneupane please request $187.50 via NewDot and let us know here once that's complete!

sobitneupane · 2023-10-31T05:14:40Z

Requested payment on newDot.

joekaufmanexpensify · 2023-10-31T12:10:51Z

TY! Closing as this is all set.

JmillsExpensify · 2023-11-03T22:27:29Z

$187.50 payment approved for @sobitneupane based on summary above.

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2023

melvin-bot bot assigned joekaufmanexpensify Oct 12, 2023

OSBotify mentioned this issue Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

mountiny added the External Added to denote the issue can be worked on by a contributor label Oct 12, 2023

melvin-bot bot changed the title ~~Attachment - Modal error does not appear after uploading an attachment larger then 24MB~~ [$500] Attachment - Modal error does not appear after uploading an attachment larger then 24MB Oct 12, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023

melvin-bot bot assigned sobitneupane Oct 12, 2023

mountiny changed the title ~~[$500] Attachment - Modal error does not appear after uploading an attachment larger then 24MB~~ [$125] Attachment - Modal error does not appear after uploading an attachment larger then 24MB Oct 12, 2023

jasperhuangg mentioned this issue Oct 12, 2023

Allow detaching receipts from transactions #26219

Merged

59 tasks

luacmartins self-assigned this Oct 12, 2023

luacmartins assigned ishpaul777 Oct 12, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023

luacmartins mentioned this issue Oct 12, 2023

Fix attachment file modal #29513

Closed

59 tasks

ishpaul777 mentioned this issue Oct 12, 2023

[$500] IOU - In distance request paid transaction,receipt delete option is shown. #29475

Closed

6 tasks

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 20, 2023

melvin-bot bot added the Overdue label Oct 23, 2023

melvin-bot bot removed the Overdue label Oct 23, 2023

melvin-bot bot added the Overdue label Oct 30, 2023

melvin-bot bot removed the Overdue label Oct 30, 2023

joekaufmanexpensify closed this as completed Oct 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$125] Attachment - Modal error does not appear after uploading an attachment larger then 24MB #29452

[HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$125] Attachment - Modal error does not appear after uploading an attachment larger then 24MB #29452

lanitochka17 commented Oct 12, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

ishpaul777 commented Oct 12, 2023 •

edited

Loading

luacmartins commented Oct 12, 2023

ishpaul777 commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

luacmartins commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

jasperhuangg commented Oct 13, 2023

ishpaul777 commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023 •

edited by joekaufmanexpensify

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by joekaufmanexpensify

Loading

joekaufmanexpensify commented Oct 20, 2023

joekaufmanexpensify commented Oct 23, 2023

ishpaul777 commented Oct 23, 2023

joekaufmanexpensify commented Oct 23, 2023

ishpaul777 commented Oct 23, 2023

joekaufmanexpensify commented Oct 24, 2023

joekaufmanexpensify commented Oct 25, 2023

joekaufmanexpensify commented Oct 26, 2023

melvin-bot bot commented Oct 30, 2023

sobitneupane commented Oct 30, 2023 •

edited

Loading

joekaufmanexpensify commented Oct 30, 2023

joekaufmanexpensify commented Oct 30, 2023

joekaufmanexpensify commented Oct 30, 2023

joekaufmanexpensify commented Oct 30, 2023

sobitneupane commented Oct 31, 2023

joekaufmanexpensify commented Oct 31, 2023

JmillsExpensify commented Nov 3, 2023

[HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$125] Attachment - Modal error does not appear after uploading an attachment larger then 24MB #29452

[HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$125] Attachment - Modal error does not appear after uploading an attachment larger then 24MB #29452

Comments

lanitochka17 commented Oct 12, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

ishpaul777 commented Oct 12, 2023 • edited Loading

Proposal

Problem

Root Cause

Changes

luacmartins commented Oct 12, 2023

ishpaul777 commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

luacmartins commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

jasperhuangg commented Oct 13, 2023

ishpaul777 commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023 • edited by joekaufmanexpensify Loading

melvin-bot bot commented Oct 16, 2023 • edited by joekaufmanexpensify Loading

joekaufmanexpensify commented Oct 20, 2023

joekaufmanexpensify commented Oct 23, 2023

ishpaul777 commented Oct 23, 2023

joekaufmanexpensify commented Oct 23, 2023

ishpaul777 commented Oct 23, 2023

joekaufmanexpensify commented Oct 24, 2023

joekaufmanexpensify commented Oct 25, 2023

joekaufmanexpensify commented Oct 26, 2023

melvin-bot bot commented Oct 30, 2023

sobitneupane commented Oct 30, 2023 • edited Loading

joekaufmanexpensify commented Oct 30, 2023

joekaufmanexpensify commented Oct 30, 2023

joekaufmanexpensify commented Oct 30, 2023

joekaufmanexpensify commented Oct 30, 2023

sobitneupane commented Oct 31, 2023

joekaufmanexpensify commented Oct 31, 2023

JmillsExpensify commented Nov 3, 2023

lanitochka17 commented Oct 12, 2023 •

edited by melvin-bot bot

Loading

ishpaul777 commented Oct 12, 2023 •

edited

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by joekaufmanexpensify

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by joekaufmanexpensify

Loading

sobitneupane commented Oct 30, 2023 •

edited

Loading