[$500] IOU - In distance request paid transaction,receipt delete option is shown.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on any Workspace chat
3. Tap request money-- distance
4. Enter start and finish waypoints
5. Tap next
6. Tap request amount
7. Tap on the transaction
8. Tap pay elsewhere and pay it
9. Tap on the receipt and open 3dots
10. Tap delete receipt

Expected Result:

In paid transaction, delete option must not be shown or if shown, receipt must be deleted if tapped on delete

Actual Result:

In paid transaction,receipt delete option is shown. But, tapping on delete, neither receipt is not deleted nor does not trigger any action

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Bug6234676_1697126185028.dis.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013adc8210e018e835
• Upwork Job ID: 1712627607226855424
• Last Price Increase: 2023-10-13
• Automatic offers:
• ishpaul777 | Contributor | 27170142

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Proposal

Problem

In distance request paid transaction,receipt delete option is shown.

Root Cause

We are showing The delete modal based on below conditions.

if (TransactionUtils.hasReceipt(props.transaction) && !TransactionUtils.isReceiptBeingScanned(props.transaction)) {
// show delete option

so when a receipt is settled, above 2 conditons remains true so deleted option is shown.

Changes

We should add ReportUtils.isSettled(props.parentReport.reportID); (we have a variable isSettled) too, if we dont want receipt to be deleted if settled.

if (TransactionUtils.hasReceipt(props.transaction) && !TransactionUtils.isReceiptBeingScanned(props.transaction) && !isSettled) {
           menuItems.push({
               icon: Expensicons.Trashcan,
               text: props.translate('receipt.deleteReceipt'),
               onSelected: () => {
                   setIsDeleteReceiptConfirmModalVisible(true);
               },
           });
   }
       

[hoangzinh]

Regression PR #26219.

[jasperhuangg]

@ishpaul777 are you available to submit a PR right now?

[ishpaul777]

Yes I can take this along with PR for #29452

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013adc8210e018e835

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

CPed to staging

[peterdbarkerUK]

Not 100% sure if I'm best manually updating this to hold-for-payment 2023-10-20, or adding it to this one. Checked in with @joekaufmanexpensify , switching to daily so I keep it up to date.

[melvin-bot]

@Li357, @peterdbarkerUK, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[peterdbarkerUK]

@ishpaul777 - the root cause here as the same as #29452 right?

[ishpaul777]

no root cause and issue was different but taken care of in one PR, because both were Deploy blockers requires quick fix

[peterdbarkerUK]

Thanks for the quick clarification.

Summarizing payouts for this issue:

Contributor: @ishpaul777 $750 (inc. urgency bonus)

Upwork job: https://www.upwork.com/nx/wm/workroom/35123916/overview

[peterdbarkerUK]

Ah shoot, I was confused about the step-ordering here across the two issues - I should not have paid this out until this BZ Checklist was completed. Keeping this open with an eye on that in the meantime.

[peterdbarkerUK]

(I think it's fine as that checklist is waiting on the C+ - I'm just leaving a clear paper trail to save my poor, poor brain from having to remember things)

[melvin-bot]

@Li357, @peterdbarkerUK, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ishpaul777]

@peterdbarkerUK We can close this as Checklist is completed #29452 (comment)