-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Threads Searchable #19117
Make Threads Searchable #19117
Conversation
@stitesExpensify @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I'm going to jump in and review this since I have some time and it's interesting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grgia would you please fill out the test and QA sections? It's pretty self explanatory so I'll go ahead and continue to test, but let's not skip filling it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests I used:
- Create a thread in a DM
- Navigate back to the parent report
- Verify the thread shows on the search page, with the same appearance as in the LHN.
- Click on the thread from the search page and verify you are navigated correctly
- Same for group chat
- Same for workspace chat
- Same for workspace room
- Same for a sub thread
The appearance of threads on a workspace chat doesn't look quite right in the LHN or the search, but we can fix that bug separately.
There's an inconsistency between the LHN and Search page for threads on messages workspace rooms. We probably want to match the LHN.
All the other cases look great.
Also there's a lint error. |
@neil-marcellini merging main fixed the matching headers and #19185 addresses the incorrect header for workspace non-room chats! Also, my bad for forgetting to update the test steps, I added yours and I appreciate you sending them! |
I think I experienced something unexpected. Here are the steps -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, the issues from my last review were fixed as you noted. I think we're really close on this, one small thing.
I'm seeing the same problem that @thesahindia pointed out. If I create a new thread on a message but don't send a message in the thread, it shows in the LHN but not on the search page. The message I threaded is "My message I'm going to thread" sent in a DM with "Neil Chat".
looking into that bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
@neil-marcellini @thesahindia that bug should be fixed by this PR which hides threads reports opened with no messages https://github.com/Expensify/App/pull/19375/files |
@grgia thanks for linking the PR to fix that bug. It looks like there's some merge conflicts, let me know when those are resolved in case a re-review is required. @thesahindia will probably want to review once more before we merge. |
7ca93e5
@neil-marcellini @thesahindia merged main, ready for final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one NAB
const title = ReportUtils.getReportName(report); | ||
const chatRoomSubtitle = ReportUtils.getChatRoomSubtitle(report); | ||
|
||
Array.prototype.push.apply(searchTerms, title.split(/[,\s]/)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB A comment here would be nice to explain what we're doing with this regex
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.19-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.19-7 🚀
|
Details
Make threads appear in the search bar.
Fixed Issues
$ #19043
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android