[$1000] Search - Only one of threads/chats is shown on search page for threads in direct and group messages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #19117

Action Performed:

1. Login to NewDot
2. Start a direct message
3. Create a thread in direct message chat
4. Request money from the same account

Expected Result:

All threads and parental chat should be shown on search page

Actual Result:

Only one (probably most recent) thread is shown on search page. F.e. if you request money, then it's thread can be found on search page but parental chat and other threads will not be found.
Not repro for workspace rooms and chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19.1

Reproducible in staging?: yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/23b64fe4bde4b7eec313342b33d3603db83c64a932b8ac60c592ee20ed82c489

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0117b1da3de9bed21c
• Upwork Job ID: 1663249040525082624
• Last Price Increase: 2023-05-29

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show threads also in Search Page for all chats on clicking search button on top.

What is the route cause of that problem?

Following lines do not push threads of the same login email to recentReportOptions
Lines 674 to 677 of App/src/libs/OptionsListUtils.js

// Check the report to see if it has a single participant and if the participant is already selected
if (reportOption.login && _.some(loginOptionsToExclude, (option) => option.login === reportOption.login)) {
     continue;
}

What changes do you think we should make in order to solve the problem?

When we want to include all threads include includeThreads flag in the above check. Change it to

if (!includeThreads && reportOption.login && _.some(loginOptionsToExclude, (option) => option.login ===  reportOption.login)) {
       continue;
 }

What alternative solutions did you explore? (Optional)

Remove the above line so that all threads are pushed into the returning recentReports

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[luacmartins]

This solves a deploy blocker, so I'll take over to get it done fast.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0117b1da3de9bed21c

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Current assignee @luacmartins is eligible for the External assigner, not assigning anyone new.

[luacmartins]

@c3024 This solves a deploy blocker. Are you able to put up a PR soon?

[luacmartins]

I put up a PR already. Since I used @c3024's solution, we should still pay them for the issue.

[melvin-bot]

📣 @c3024 You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[c3024]

Thank you @luacmartins . I could not see your message right away. I see now that the change suggested has been implemented. I have applied for the job in Upwork.

[conorpendergrast]

I'll get that paid; @c3024 thanks for applying!

[conorpendergrast]

@c3024 I see two applicants in that job; could you reply here with your Upwork profile link please? Thanks!

[c3024]

Here is the link https://www.upwork.com/freelancers/~0105555e2f227dbf47 . Thanks @conorpendergrast

[conorpendergrast]

Offer sent

[c3024]

Accepted. Thanks. The PR has already been merged.

[conorpendergrast]

Paid! All done now, closing