Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-19] Fix Header subtitle for workspace chats #19186

Closed
grgia opened this issue May 18, 2023 · 15 comments
Closed

[HOLD for payment 2023-06-19] Fix Header subtitle for workspace chats #19186

grgia opened this issue May 18, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented May 18, 2023

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011b9003e769e27cb3
  • Upwork Job ID: 1659152498133979136
  • Last Price Increase: 2023-05-18

#19117 (review)

Thread header for workspace chat looks like <Workspace Name> • and it should be just <Workspace Name>

@grgia grgia self-assigned this May 18, 2023
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label May 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~011b9003e769e27cb3

@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Monthly KSv2 labels May 18, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jun 12, 2023
@melvin-bot melvin-bot bot changed the title Fix Header subtitle for workspace chats [HOLD for payment 2023-06-19] Fix Header subtitle for workspace chats Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

@grgia, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

@grgia grgia added the Bug Something is broken. Auto assigns a BugZero manager. label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as off-topic.

@grgia
Copy link
Contributor Author

grgia commented Jun 26, 2023

@flaviadefaria this didn't ave a BZ assigned- we just need to handle C+ review payment for #19185 (merged and ready for payment now)

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2023
@Santhosh-Sellavel
Copy link
Collaborator

@flaviadefaria For payment I'm just waiting for the internal process, please check here. So please wait for further comments thanks!

@flaviadefaria
Copy link
Contributor

@grgia can you confirm if payment should be $1000 or less?
@Santhosh-Sellavel since this is already due for payment and the internal process is not live yet then I'll pay this through UW and we can start using Expensify once the process is live.

@grgia
Copy link
Contributor Author

grgia commented Jun 28, 2023

Yes should be $1000 for C+ review

@flaviadefaria
Copy link
Contributor

Offer sent in UW!

@flaviadefaria
Copy link
Contributor

@Santhosh-Sellavel can you please accept the offer so we can close this GH? 🙏

@melvin-bot melvin-bot bot added the Overdue label Jul 3, 2023
@flaviadefaria
Copy link
Contributor

@Santhosh-Sellavel I'm closing this as complete. Whenever you want to receive the payment for the work done here please accept the offer in Upwork.

@melvin-bot melvin-bot bot removed the Overdue label Jul 3, 2023
@anmurali
Copy link

anmurali commented Jul 7, 2023

@Santhosh-Sellavel gets paid via manual requests on New Dot. I just approved this request and paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants