Swap out trivial usages of sequenceNumber in UI keys #12606

roryabraham · 2022-11-09T19:01:44Z

Details

Part of deprecating sequence numbers

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/240875

Tests / QA Steps

Web/Desktop

Open a chat with multiple messages.
Hover over some messages in the report
Verify that the mini context menu that appears for the message on hover is fully visible and overlaps the message above.

iOS/Android/mWeb

None

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

techievivek

Looks good and tests well. 🎉

mananjadhav · 2022-11-10T17:43:16Z

I am just in process of testing this. Just saw the commit, let me take the latest pull.

mananjadhav · 2022-11-10T18:34:16Z

Change is fine and tests well.

@roryabraham For mWeb Chrome, the screenshot is not inline, with the other platforms.

🎀 👀 🎀
C+ reviewed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2022-11-11T00:58:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-11T03:39:09Z

🚀 Deployed to staging by @roryabraham in version: 1.2.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2022-11-11T18:20:19Z

src/pages/home/report/ReportActionsList.js

@@ -109,7 +109,7 @@ class ReportActionsList extends React.Component {
     * @return {String}
     */
    keyExtractor(item) {
-        return `${item.action.clientID}${item.action.reportActionID}${item.action.sequenceNumber}`;
+        return `${item.action.clientID}${item.action.reportActionID}`;


Do we still need the clientID if we are switching to reportActionID and there will only ever be one?

Good call, we don't need clientID because we're assuming that reportActionID is random enough to be universally unique

OSBotify · 2022-11-15T21:09:53Z

🚀 Deployed to production by @roryabraham in version: 1.2.27-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2022-11-16T00:17:46Z

🚀 Deployed to production by @roryabraham in version: 1.2.27-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav · 2022-11-22T14:23:09Z

@roryabraham This is ready for C+ review payout. Can you please help with this?

roryabraham · 2022-11-24T23:50:39Z

@mananjadhav @JmillsExpensify created an upwork job linked to the internal issue for this C+ review payout: https://www.upwork.com/jobs/~019b3e8a37dbfe9d94

mananjadhav · 2022-11-25T01:54:24Z

Thanks @roryabraham. @JmillsExpensify I've applied on Upwork

JmillsExpensify · 2022-11-26T18:16:57Z

Thanks, sent an offer on Upwork. I'll close out the linked issue when @mananjadhav accepts and payment is issued.

JmillsExpensify · 2022-11-26T19:08:11Z

Payment issued!

roryabraham added 2 commits November 9, 2022 10:41

Swap out trivial usages of sequenceNumber in keys

911f510

Swap out usage of sequenceNumber for zIndex

3d0e775

roryabraham self-assigned this Nov 9, 2022

Fix JS style

9f4a93b

roryabraham marked this pull request as ready for review November 9, 2022 19:53

roryabraham requested a review from a team as a code owner November 9, 2022 19:53

melvin-bot bot requested review from mananjadhav and techievivek and removed request for a team November 9, 2022 19:54

Fix JS style (again)

2168f20

roryabraham mentioned this pull request Nov 9, 2022

Sort reportActions by created instead of sequenceNumber #12626

Merged

94 tasks

techievivek approved these changes Nov 10, 2022

View reviewed changes

Merge branch 'main' into Rory-SequenceNumReportActionID

6b96ed9

mananjadhav approved these changes Nov 10, 2022

View reviewed changes

roryabraham merged commit 40e1278 into main Nov 11, 2022

roryabraham deleted the Rory-SequenceNumReportActionID branch November 11, 2022 00:54

OSBotify mentioned this pull request Nov 11, 2022

Deploy Checklist: New Expensify 2022-11-11 #12662

Closed

27 tasks

dangrous mentioned this pull request Nov 11, 2022

Android - Chat - App is crashed after sent the message #12666

Closed

marcaaron reviewed Nov 11, 2022

View reviewed changes

This was referenced Nov 11, 2022

Clicking on context menu item does nothing. #12685

Closed

[$250] Chat- Unable to select any option in mini content, the menu moves up when trying to hover over it #12687

Closed

JmillsExpensify requested review from JmillsExpensify and removed request for JmillsExpensify November 26, 2022 18:15

JmillsExpensify mentioned this pull request Nov 29, 2022

Swap out mostRecentIOUReportSequenceNumber for mostRecentIOUReportActionID #12604

Merged

91 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swap out trivial usages of sequenceNumber in UI keys #12606

Swap out trivial usages of sequenceNumber in UI keys #12606

roryabraham commented Nov 9, 2022 •

edited

Loading

techievivek left a comment

mananjadhav commented Nov 10, 2022

mananjadhav commented Nov 10, 2022 •

edited

Loading

OSBotify commented Nov 11, 2022

OSBotify commented Nov 11, 2022

marcaaron Nov 11, 2022

roryabraham Nov 12, 2022

OSBotify commented Nov 15, 2022

OSBotify commented Nov 16, 2022

mananjadhav commented Nov 22, 2022

roryabraham commented Nov 24, 2022

mananjadhav commented Nov 25, 2022

JmillsExpensify commented Nov 26, 2022

JmillsExpensify commented Nov 26, 2022

Swap out trivial usages of sequenceNumber in UI keys #12606

Swap out trivial usages of sequenceNumber in UI keys #12606

Conversation

roryabraham commented Nov 9, 2022 • edited Loading

Details

Fixed Issues

Tests / QA Steps

Web/Desktop

iOS/Android/mWeb

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

techievivek left a comment

Choose a reason for hiding this comment

mananjadhav commented Nov 10, 2022

mananjadhav commented Nov 10, 2022 • edited Loading

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify commented Nov 11, 2022

OSBotify commented Nov 11, 2022

marcaaron Nov 11, 2022

Choose a reason for hiding this comment

roryabraham Nov 12, 2022

Choose a reason for hiding this comment

OSBotify commented Nov 15, 2022

OSBotify commented Nov 16, 2022

mananjadhav commented Nov 22, 2022

roryabraham commented Nov 24, 2022

mananjadhav commented Nov 25, 2022

JmillsExpensify commented Nov 26, 2022

JmillsExpensify commented Nov 26, 2022

roryabraham commented Nov 9, 2022 •

edited

Loading

mananjadhav commented Nov 10, 2022 •

edited

Loading