Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-11-11 #12662

Closed
27 tasks done
OSBotify opened this issue Nov 11, 2022 · 15 comments
Closed
27 tasks done

Deploy Checklist: New Expensify 2022-11-11 #12662

OSBotify opened this issue Nov 11, 2022 · 15 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Nov 11, 2022

Release Version: 1.2.27-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Nov 11, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.27-0 🚀

@dangrous
Copy link
Contributor

#12401 can no longer be QAed so checking it off cc @cead22

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.27-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.27-3 has been deployed to staging 🎉

@mvtglobally
Copy link

Regression is completed

PR #11751 is failing #7270 and Native apps are blocked due to #11796. Are we ok to check off?
PR #12157 is failing #12637 #12671 #11961 #11858
PR #12181 is blocked by #12530
PR #12282 is pass on Web, but we are blocked to check on other platforms. Are we ok to check off?
PR #12628 does not have deeplink on Desktop app, rest platforms are pass. Checking off
PR #12688 all pass, but Android. App didnt update yet
Checking CP #12679. will update in the morning

@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 14, 2022
@mvtglobally
Copy link

We also do not see the latest Android build 1.2.27-3

@roryabraham
Copy link
Contributor

Retrying Android deploy for 1.2.27-3

@roryabraham
Copy link
Contributor

Android 1.2.27-3 should be available now

@mvtglobally
Copy link

Checking off #12679 & #12688

Outstanding items
PR #11751 is failing #7270 and Native apps are blocked due to #11796. Are we ok to check off?
PR #12157 is failing #12637 #12671 #11961 #11858
PR #12181 is blocked by #12530
PR #12282 is pass on Web, but we are blocked to check on other platforms. Are we ok to check off?

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.27-4 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.27-4 has been deployed to staging 🎉

@mvtglobally
Copy link

Checking off #12722

@roryabraham
Copy link
Contributor

Timing graphs are a bit all over the place but we seem to be on a downward trend, and there was a post-mortem sent out yesterday for a performance regression that has been fixed, so we should be okay to deploy.

@roryabraham
Copy link
Contributor

No new crashes in this version either:

image

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants