BUG: Adding a personal bank account causes a crash

[neil-marcellini]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Sign in with any account
2. Go to Settings, Payments, Add payment method, bank account
3. Connect through Plaid with a test account
4. After the connection succeeds click continue

Expected Result:

The bank account is added and shows up in the app

Actual Result:

There is a loading spinner for a while and then the app crashes

Workaround:

No

Platform:

Probably all platforms but we need to check.

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.2.24-2
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

bank-account-crash.mov

Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1667851355646509

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[neil-marcellini]

As decided in slack here we will hold this on #12308 and see if we can reproduce after it is fixed.

[alexpensify]

I've asked if we should move this to a weekly or leave it as a daily.

[alexpensify]

I've confirmed it's possible to move to weekly and I'm setting a reminder to check the status.

[alexpensify]

I checked and it looks like this one is still under review. Setting another reminder for Friday and might have to reassign due to being OOO next week.

[nkuoch]

The other one seems not be reproducible. Can anyone check if this one is reproducible? I personally couldn't reproduce it.

[alexpensify]

I tested per @nkuoch request and was able to replicate in my [email protected] account using @neil-marcellini's steps.

When I log back in, the bank account is not there.

[nkuoch]

I can't reproduce it, but from Al's logs, seems like we're getting:

alXt] NewExpensify crash caught by error boundary - Minified React error #185; visit https://reactjs.org/docs/error-decoder.html?invariant=185 for the full message or use the non-minified dev environment for full errors and additional helpful warnings. ~~ errorInfo: '{"componentStack":"\n at a (app://-/main-6415f669a262c0246388.bundle.js:2:5127210)

Which leads to:

Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.

[nkuoch]

@alexpensify are you testing from chrome? Do you have the same error after you clear your cookies? If yes, would you mind sharing your credentials with me so I can hopefully reproduce myself?

[alexpensify]

I was testing via the desktop app. Do you want me to try in chrome?

[nkuoch]

Yes please

…

On Nov 21, 2022, at 17:38, Al Garces ***@***.***> wrote:  I was testing via the desktop app. Do you want me to try in chrome? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[nkuoch]

@neil-marcellini as al is ooo, could you test on chrome and tell me if you still have the issue? If yes, does clearing our your cookies fix it? Yes no, could you share your credentials with me so I can reproduce and investigate?

[neil-marcellini]

Sure I'll try it now.

[neil-marcellini]

I'm no longer able to reproduce, we can close this 🙂