Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] [$250] Connect Bank Account - App is crashed when adding a Verified Bank Account #12308

Closed
kbecciv opened this issue Oct 31, 2022 · 30 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Oct 31, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Enable staging Web secure server in Account Preferences if disabled
  4. Navigate to the add bank account modal (Workspace settings > Add bank account)
  5. Verify the Add bank account modal is displayed with 2 options to add bank accounts (Log in and Manual)
  6. Select the Connect with plaid method to add a bank account
  7. On the bank account list select "Fidelity"
  8. Enter the credentials "user_good / pass_good"
  9. Select "Plaid Saving" account
  10. Click Save and Continue
  11. In the company information verify all fields are working as expected
  12. Fill out the fields with the required test credentials
  13. Verify you're able to continue to the personal information step.
  14. In the Personal information verify all fields are working as expected
  15. Fill out the fields with the required test credentials
  16. Verify you're able to continue.
  17. In the beneficial owners step toggle the last 2 checkboxes (terms and conditions and true information)
  18. Confirm you're able to continue and reach the validate step.
  19. Verify the bank account was added to the workspace

Expected Result:

App is not crashed when adding Verified Bank Account

Actual Result:

App is crashed when adding a Verified Bank Account

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • mWeb/Safari
    mWeb//Chrome

Version Number: 1.2.21.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1553.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2022

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Julesssss
Copy link
Contributor

This was unreproducible yesterday, so there are possibly other required account configurations that cause this issue.

Until we can reliably reproduce this I don't thin it should be made external yet.

@zanyrenney
Copy link
Contributor

Thanks @Julesssss

@Julesssss
Copy link
Contributor

@Expensify/applauseleads would you mind sending testing again and on other platforms so we can get an idea of how often this occurs? Thanks in advance

@kbecciv
Copy link
Author

kbecciv commented Nov 1, 2022

@Julesssss Yes, we will do it now, update you shortly here.

@kbecciv kbecciv changed the title Web- Connect Bank Account - App is crashed when adding a Verified Bank Account Connect Bank Account - App is crashed when adding a Verified Bank Account Nov 1, 2022
@kbecciv
Copy link
Author

kbecciv commented Nov 1, 2022

@Julesssss Issue is reproduced on Web, mWeb/safari and mWeb/Chrome.
We are blocked to test on IOS and Android app due to KI

Recording.1666.mp4
mweb.12308.mp4
Screen_Recording_20221101-125509_Chrome.mp4

@Julesssss
Copy link
Contributor

Hi, thanks for that.

We are blocked to test on IOS and Android app due to KI

What do you mean by KI? Sorry, but I don't remember what that stands for 😅

@Julesssss
Copy link
Contributor

Julesssss commented Nov 2, 2022

@zanyrenney I'm on the fence about making this a deploy blocker. @chiragsalian was not able to reproduce this and I'm blocked at test step 14 currently, are you able to reproduce? If you're also stuck I'll ask for help testing in Slack

@Julesssss
Copy link
Contributor

I asked for someone to help confirm this issue in Slack here, but I have managed to reproduce the issue in web:

Screenshot 2022-11-02 at 11 06 17

@Julesssss Julesssss added the Internal Requires API changes or must be handled by Expensify staff label Nov 2, 2022
@Julesssss
Copy link
Contributor

Marking internal as it seems to depend on the environment. I cannot reproduce in dev 😕

Here's the Logs for my attempt:

Screenshot 2022-11-02 at 11 36 42

@Julesssss Julesssss self-assigned this Nov 2, 2022
@Julesssss
Copy link
Contributor

Julesssss commented Nov 2, 2022

Okay, so the bank account data is definitely being added to Onyx, but for some reason it's no retrieved from the key subscription when the check is made 😕 As the workaround is to simply refresh the page and it's already on prod, I'm not going to make this a major blocker. But it is still important.

BankAccountFailure.mov

@Julesssss Julesssss added Weekly KSv2 Daily KSv2 and removed Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 labels Nov 2, 2022
@Julesssss Julesssss assigned zanyrenney and unassigned Julesssss and zanyrenney Nov 2, 2022
@Julesssss Julesssss self-assigned this Nov 2, 2022
@kbecciv
Copy link
Author

kbecciv commented Nov 2, 2022

@Julesssss This is open KI #11796 for IOS and Android app

@zanyrenney
Copy link
Contributor

zanyrenney commented Nov 7, 2022

No propsals yet. Upwork is linked here: https://www.upwork.com/jobs/~015e36e7199e95417d

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@JmillsExpensify
Copy link

Can someone on this issue re-test and see if they get the same result as Applause?

@melvin-bot melvin-bot bot added the Overdue label Nov 10, 2022
@Julesssss
Copy link
Contributor

I can't get to this today, will do at the next overdue ping

@melvin-bot melvin-bot bot removed the Overdue label Nov 10, 2022
@JmillsExpensify
Copy link

I just tried testing but I got an error trying to get past Onfido.
IMG_1818263A2EC5-1

@melvin-bot
Copy link

melvin-bot bot commented Nov 14, 2022

@Julesssss, @parasharrajat, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2022
@Julesssss
Copy link
Contributor

Hey @mvtglobally would you mind retesting again, as we couldn't reproduce this last time and we are having trouble verifying ourselves.

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2022
@JmillsExpensify
Copy link

Yes, thanks @mvtglobally! Let us know how testing goes.

@JmillsExpensify JmillsExpensify added the Needs Reproduction Reproducible steps needed label Nov 15, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Nov 16, 2022
@Julesssss Julesssss changed the title [$250] Connect Bank Account - App is crashed when adding a Verified Bank Account [HOLD] [$250] Connect Bank Account - App is crashed when adding a Verified Bank Account Nov 17, 2022
@Julesssss
Copy link
Contributor

Holding this while the retesting is completed, it's possible this is no longer occuring 🤞

@melvin-bot melvin-bot bot removed the Overdue label Nov 17, 2022
@zanyrenney
Copy link
Contributor

zanyrenney commented Nov 17, 2022

Could have been a tempoprary issue, but as we we close after 4 weeks restests, We'll keep the issue open 2 more weeks for these retests.

@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

@Julesssss, @parasharrajat, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 21, 2022
@zanyrenney
Copy link
Contributor

Keeping open until retesting is complete.

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week) Can we close this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

6 participants