[HOLD for payment 2023-12-04] [CRITICAL] Migrate the LHNOptionsList to Flashlist

[mountiny]

HOLD on #30242

Part of #28902

Let's migrate LHNOptionsList to use Flashlist component instead of FlatList

Callstack is working on the migration right now.

Lets use this issue for daily updates on this migration

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[TMisiukiewicz]

Hi, I'm Tomasz from Callstack, I'd like to work on that issue

[TMisiukiewicz]

Waiting for #30242 to be reviewed and merged, once it's done I'll create a proper PR

[roryabraham]

Ok, then let's put this one HOLD for that

[TMisiukiewicz]

#30242 is merged now, we can remove hold status

[garrettmknight]

Hold status removed.

[TMisiukiewicz]

Most of the work is done here, i just need to double check it on all platforms. Tomorrow morning i should send it for internal review and then create a PR

[garrettmknight]

Looks like @TMisiukiewicz was off for a few days - we'll get back to this on Monday.

[melvin-bot]

@garrettmknight, @TMisiukiewicz, @roryabraham Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@garrettmknight, @TMisiukiewicz, @roryabraham Huh... This is 4 days overdue. Who can take care of this?

[TMisiukiewicz]

Still working on fixing the tests, described details in a comment under a PR

[TMisiukiewicz]

Unit tests are green now, hovewer one reassure test is failing. Gonna investigate it tomorrow.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[TMisiukiewicz]

Trying to figure out if the regression #31610 comes from this PR, but I can't reproduce it. The logic for displaying the skeleton remains the same, the only thing that changed were styles. Left the more detailed comment here. IMO it is very unlikely that the regression comes from the PR, since the logic behind displaying the skeleton is the same as before.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [perf] Migrate LHNOptionList to FlashList #31711

If no regressions arise, payment will be issued on 2023-12-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @TMisiukiewicz does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@TMisiukiewicz] Determine if we should create a regression test for this bug.
• [@TMisiukiewicz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

@TMisiukiewicz Good to close?

[situchan]

yes, only C+ payment for PR review is remaining

[garrettmknight]

@situchan I think payment for that PR should get handled in #31610. Is there something I'm missing here?

[melvin-bot]

@garrettmknight, @TMisiukiewicz, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

[garrettmknight]

Not overdue, confirming which issue to pay on.

[situchan]

#31610 is for #31642 (I was PR author)
#30910 is for #31711 (I was PR reviewer)

[garrettmknight]

Got it - thanks for clarifying. Offer's out to you.

[garrettmknight]

And paid! Closing