[HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account #31803

kbecciv · 2023-11-23T22:01:02Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Login with HT account - [email protected]

Expected Result:

Verify the UI has a loading "skeleton" state (offline avatar and placeholder lines) and loads after a few moments and the loading state is not visible anymore

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6288979_1700775441466.Recording__256.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01eec53be34df7522e
Upwork Job ID: 1735048003260628992
Last Price Increase: 2023-12-13

github-actions · 2023-11-23T22:01:18Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-11-23T22:01:21Z

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot · 2023-11-23T22:01:22Z

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

situchan · 2023-11-23T22:08:29Z

@kbecciv do you have any crash log or console error?

luacmartins · 2023-11-23T22:15:15Z

I suspect it might be coming from this PR - #31711. Gonna try to help @aldo-expensify reproduce this issue first

luacmartins · 2023-11-23T22:18:24Z

Hmm actually, I'm seeing the crash log below without a HT account

situchan · 2023-11-23T22:19:27Z

Seems like what @quinthar reported here

luacmartins · 2023-11-23T22:22:31Z

Seems to come from this line

App/src/libs/OptionsListUtils.js

Line 396 in 1163dc3

const actorID = report.managerID || reportAction.actorAccountID;

situchan · 2023-11-23T22:23:23Z

#31061 is candidate

luacmartins · 2023-11-23T22:30:24Z

Yea, I'm trying to reproduce in dev

aldo-expensify · 2023-11-23T22:49:04Z

Seems to come from this line

App/src/libs/OptionsListUtils.js

Line 396 in 1163dc3

const actorID = report.managerID || reportAction.actorAccountID;

For this to happen, we would need to fail to find the IOU here

App/src/libs/OptionsListUtils.js

Lines 425 to 431 in 36105a3

    
           const lastIOUMoneyReport = _.find( 
        
               allSortedReportActions[iouReport.reportID], 
        
               (reportAction, key) => 
        
                   ReportActionUtils.shouldReportActionBeVisible(reportAction, key) && 
        
                   reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && 
        
                   ReportActionUtils.isMoneyRequestAction(reportAction), 
        
           );

luacmartins · 2023-11-23T22:53:34Z

correct, this is the data I have. You can see that the reportID doesn't exist in allSortedReportActions and lastIOUMoneyReport is undefined

aldo-expensify · 2023-11-23T22:57:07Z

Reproduced:

Have 2 accounts logged in different sessions and start a chat between them
Request money from one of them
The other received the pusher event and crash

Going to check if this happens in production

aldo-expensify · 2023-11-23T23:01:56Z

hmm I have been only able to reproduce in dev, but not ~staging/~production

Reproduced in staging.

aldo-expensify · 2023-11-23T23:08:07Z

hmm, pusher events are not working anymore in my env...

luacmartins · 2023-11-23T23:09:11Z

I have a fix for it here - https://github.com/Expensify/Web-Expensify/pull/39825

aldo-expensify · 2023-11-23T23:16:41Z

This is the pusher events that cause the things to explode:

{
    "updates": [
        {
            "data": [
                {
                    "key": "report_3759538206565919",
                    "onyxMethod": "merge",
                    "value": {
                        "lastActorAccountID": 11033970,
                        "lastMentionedTime": null,
                        "lastMessageText": "$2.00 request",
                        "lastReadTime": null,
                        "lastVisibleActionCreated": "2023-11-23 23:11:15.398",
                        "maxSequenceNumber": 1,
                        "reportID": "3759538206565919"
                    }
                },
                {
                    "key": "reportActions_3759538206565919",
                    "onyxMethod": "merge",
                    "shouldNotify": true,
                    "value": {
                        "9135915664676949581": {
                            "actionName": "IOU",
                            "actorAccountID": 11033970,
                            "automatic": false,
                            "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_19.png",
                            "childReportID": 1130822545444080,
                            "childType": "chat",
                            "created": "2023-11-23 23:11:15.398",
                            "isAttachment": false,
                            "lastModified": "2023-11-23 23:11:15.398",
                            "message": [
                                {
                                    "html": "$2.00 request",
                                    "isDeletedParentAction": false,
                                    "isEdited": false,
                                    "reactions": [],
                                    "text": "$2.00 request",
                                    "type": "COMMENT",
                                    "whisperedTo": []
                                }
                            ],
                            "originalMessage": {
                                "IOUReportID": 3759538206565919,
                                "IOUTransactionID": "1282493847044555760",
                                "amount": 200,
                                "comment": "",
                                "currency": "USD",
                                "lastModified": "2023-11-23 23:11:15.398",
                                "participantAccountIDs": [
                                    11033970,
                                    11033972
                                ],
                                "type": "create"
                            },
                            "person": [
                                {
                                    "style": "strong",
                                    "text": "[email protected]",
                                    "type": "TEXT"
                                }
                            ],
                            "previousReportActionID": "7277686818659270939",
                            "reportActionID": "9135915664676949581",
                            "reportActionTimestamp": 1700781075398,
                            "sequenceNumber": 1,
                            "shouldShow": true,
                            "timestamp": 1700781075,
                            "whisperedToAccountIDs": []
                        }
                    }
                },
                {
                    "key": "report_3759538206565919",
                    "onyxMethod": "merge",
                    "value": {
                        "chatReportID": "5721531069860615",
                        "chatType": "",
                        "currency": "USD",
                        "description": null,
                        "hasOutstandingChildRequest": false,
                        "hasOutstandingIOU": true,
                        "hasParentAccess": true,
                        "iouReportID": null,
                        "isDeletedParentAction": null,
                        "isOwnPolicyExpenseChat": false,
                        "isPinned": false,
                        "isWaitingOnBankAccount": false,
                        "lastActorAccountID": 11033970,
                        "lastMentionedTime": null,
                        "lastMessageHtml": "$2.00 request",
                        "lastMessageText": "$2.00 request",
                        "lastReadSequenceNumber": 0,
                        "lastReadTime": null,
                        "lastVisibleActionCreated": "2023-11-23 23:11:15.398",
                        "lastVisibleActionLastModified": "2023-11-23 23:11:15.398",
                        "managerID": 11033972,
                        "nonReimbursableTotal": 0,
                        "notificationPreference": "always",
                        "oldPolicyName": "",
                        "ownerAccountID": 11033970,
                        "parentReportActionID": "5628178967538067842",
                        "parentReportID": "5721531069860615",
                        "participantAccountIDs": [
                            11033972,
                            11033970
                        ],
                        "policyID": "769D1BB08FEC917C",
                        "policyName": null,
                        "reportID": "3759538206565919",
                        "reportName": "IOU",
                        "stateNum": 1,
                        "statusNum": 1,
                        "submitterPayPalMeAddress": "",
                        "total": 200,
                        "type": "iou",
                        "visibility": null,
                        "visibleChatMemberAccountIDs": [],
                        "welcomeMessage": "",
                        "writeCapability": "all"
                    }
                },
                {
                    "key": "report_5721531069860615",
                    "onyxMethod": "merge",
                    "value": {
                        "iouReportID": "3759538206565919",
                        "participantAccountIDs": [
                            11033970
                        ]
                    }
                },
                {
                    "key": "transactions_1282493847044555760",
                    "onyxMethod": "merge",
                    "value": {
                        "amount": 200,
                        "billable": false,
                        "cardID": 11051,
                        "category": "",
                        "comment": {
                            "comment": ""
                        },
                        "created": "2023-11-23",
                        "currency": "USD",
                        "filename": "",
                        "hasEReceipt": false,
                        "merchant": "Request",
                        "modifiedAmount": 0,
                        "modifiedCreated": "",
                        "modifiedCurrency": "",
                        "modifiedMerchant": "",
                        "originalAmount": 0,
                        "originalCurrency": "",
                        "parentTransactionID": "",
                        "receipt": [],
                        "reimbursable": true,
                        "reportID": "3759538206565919",
                        "status": "Posted",
                        "tag": "",
                        "transactionID": "1282493847044555760"
                    }
                },
                {
                    "key": "report_5721531069860615",
                    "onyxMethod": "merge",
                    "value": {
                        "hasOutstandingChildRequest": true
                    }
                },
                {
                    "key": "report_5721531069860615",
                    "onyxMethod": "merge",
                    "value": {
                        "lastActorAccountID": 11033972,
                        "lastMentionedTime": null,
                        "lastMessageText": "[email protected] owes $2.00",
                        "lastReadTime": "2023-11-23 23:11:15.408",
                        "lastVisibleActionCreated": "2023-11-23 23:11:15.408",
                        "maxSequenceNumber": 2,
                        "reportID": "5721531069860615"
                    }
                },
                {
                    "key": "reportActions_5721531069860615",
                    "onyxMethod": "merge",
                    "shouldNotify": true,
                    "value": {
                        "5628178967538067842": {
                            "actionName": "REPORTPREVIEW",
                            "actorAccountID": 11033972,
                            "automatic": false,
                            "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_24.png",
                            "childMoneyRequestCount": 1,
                            "childReportID": 3759538206565919,
                            "childStateNum": 1,
                            "childStatusNum": 1,
                            "childType": "iou",
                            "created": "2023-11-23 23:11:15.408",
                            "isAttachment": false,
                            "lastModified": "2023-11-23 23:11:15.408",
                            "message": [
                                {
                                    "html": "[email protected] owes $2.00",
                                    "isDeletedParentAction": false,
                                    "isEdited": false,
                                    "reactions": [],
                                    "text": "[email protected] owes $2.00",
                                    "type": "COMMENT",
                                    "whisperedTo": []
                                }
                            ],
                            "originalMessage": {
                                "lastModified": "2023-11-23 23:11:15.408",
                                "linkedReportID": "3759538206565919"
                            },
                            "person": [
                                {
                                    "style": "strong",
                                    "text": "[email protected]",
                                    "type": "TEXT"
                                }
                            ],
                            "previousReportActionID": "6783530264347664382",
                            "reportActionID": "5628178967538067842",
                            "reportActionTimestamp": 1700781075408,
                            "sequenceNumber": 2,
                            "shouldShow": true,
                            "timestamp": 1700781075,
                            "whisperedToAccountIDs": []
                        }
                    }
                }
            ],
            "eventType": "onyxApiUpdate"
        }
    ],
    "lastUpdateID": "7550",
    "previousUpdateID": "7544"
}

We can see here:

REPORTPREVIEW is inserted to onyx in key reportActions_5721531069860615. This has "linkedReportID": "3759538206565919"
In the same Onyx event, another update inserts the IOU report 3759538206565919

I think the problem is that the REPORTPREVIEW gets inserted causing a re-render before the IOU report is inserted. I think we should just update the front end code so it doesn't crash and display something else while we don't find the IOU report

luacmartins · 2023-11-23T23:21:47Z

Sounds good, wanna work on a fix?

aldo-expensify · 2023-11-23T23:24:28Z

@luacmartins what are your thoughts on: #31806 🙏

luacmartins · 2023-11-23T23:28:00Z

hmm but in the log I linked above iouReport is defined, we just don't have any reportAction for it in Onyx

aldo-expensify · 2023-12-06T21:16:39Z

I think there is no payment to be issues here, I'll just close this since the offending PR was reverted.

allroundexperts · 2023-12-09T02:09:41Z

Hi @aldo-expensify!

I reviewed #31817 and my payment is still pending. Can you please write a payment summary? Thanks

melvin-bot · 2023-12-12T15:33:55Z

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-12-12T15:33:57Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

aldo-expensify · 2023-12-12T15:35:26Z

@muttmuure added Bug because we need to process @allroundexperts 's payment for reviewing PR #31817

This issue is about a regression caused by PR: #31061

allroundexperts · 2023-12-12T15:37:16Z

Thanks @aldo-expensify. Can you please write a payment summary?

melvin-bot · 2023-12-13T21:23:18Z

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

melvin-bot · 2023-12-13T21:24:16Z

Job added to Upwork: https://www.upwork.com/jobs/~01eec53be34df7522e

melvin-bot · 2023-12-13T21:24:20Z

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

mallenexpensify · 2023-12-13T21:28:07Z

Contributor+: @allroundexperts owed $500 via NewDot

mallenexpensify · 2023-12-13T21:29:04Z

@allroundexperts can you complete the BZ checklist? Thx

allroundexperts · 2023-12-14T01:46:58Z

Checklist

This bug was caused by fix: fix lhn previews #31061. The author is aware of this bug.
N/A
N/A
I think a regression test is not needed here because this involved a crash after just logging in to an account. This should be already covered in prior test cases.

JmillsExpensify · 2023-12-14T05:09:45Z

$500 payment approved for @allroundexperts based on summary above.

melvin-bot · 2023-12-18T00:42:37Z

@allroundexperts, @muttmuure, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

aldo-expensify · 2023-12-18T15:51:35Z

@allroundexperts did you receive your payment?

mallenexpensify · 2023-12-19T04:44:07Z

This should all be wrapped up, so closing. Reply if you disagree!

kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 23, 2023

github-actions bot added Engineering Hourly KSv2 labels Nov 23, 2023

melvin-bot bot assigned aldo-expensify Nov 23, 2023

github-actions bot mentioned this issue Nov 23, 2023

Deploy Checklist: New Expensify 2023-11-23 #31786

Closed

60 tasks

melvin-bot bot mentioned this issue Nov 23, 2023

[Awaiting C+ payment confo] Fix issues with the LHN previews and report actions surrounding iou/expenseReports when owed and paid. #30042

Closed

6 tasks

aldo-expensify mentioned this issue Nov 23, 2023

Use message.text instead if reportAction is not available #31806

Closed

47 tasks

melvin-bot bot added Daily KSv2 Overdue labels Dec 3, 2023

aldo-expensify closed this as completed Dec 6, 2023

melvin-bot bot removed the Overdue label Dec 6, 2023

aldo-expensify reopened this Dec 12, 2023

aldo-expensify added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 12, 2023

melvin-bot bot assigned muttmuure Dec 12, 2023

mallenexpensify changed the title ~~[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Web - Login - App crashes when login to HT account~~ [HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account Dec 13, 2023

mallenexpensify added the Internal Requires API changes or must be handled by Expensify staff label Dec 13, 2023

mallenexpensify closed this as completed Dec 13, 2023

mallenexpensify reopened this Dec 13, 2023

melvin-bot bot added the Overdue label Dec 18, 2023

melvin-bot bot removed the Overdue label Dec 18, 2023

mallenexpensify closed this as completed Dec 19, 2023

[HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account #31803

[HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account #31803

Comments

kbecciv commented Nov 23, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

github-actions bot commented Nov 23, 2023

melvin-bot bot commented Nov 23, 2023

melvin-bot bot commented Nov 23, 2023

situchan commented Nov 23, 2023

luacmartins commented Nov 23, 2023

luacmartins commented Nov 23, 2023

situchan commented Nov 23, 2023

luacmartins commented Nov 23, 2023 • edited Loading

situchan commented Nov 23, 2023

luacmartins commented Nov 23, 2023

aldo-expensify commented Nov 23, 2023

luacmartins commented Nov 23, 2023 • edited Loading

aldo-expensify commented Nov 23, 2023

aldo-expensify commented Nov 23, 2023 • edited Loading

aldo-expensify commented Nov 23, 2023

luacmartins commented Nov 23, 2023 • edited Loading

aldo-expensify commented Nov 23, 2023

luacmartins commented Nov 23, 2023

aldo-expensify commented Nov 23, 2023

luacmartins commented Nov 23, 2023

aldo-expensify commented Dec 6, 2023

allroundexperts commented Dec 9, 2023

melvin-bot bot commented Dec 12, 2023

melvin-bot bot commented Dec 12, 2023

Bug0 Triage Checklist (Main S/O)

aldo-expensify commented Dec 12, 2023 • edited Loading

allroundexperts commented Dec 12, 2023

melvin-bot bot commented Dec 13, 2023

melvin-bot bot commented Dec 13, 2023

melvin-bot bot commented Dec 13, 2023

mallenexpensify commented Dec 13, 2023

mallenexpensify commented Dec 13, 2023

allroundexperts commented Dec 14, 2023

Checklist

JmillsExpensify commented Dec 14, 2023

melvin-bot bot commented Dec 18, 2023

aldo-expensify commented Dec 18, 2023

mallenexpensify commented Dec 19, 2023

kbecciv commented Nov 23, 2023 •

edited by melvin-bot bot

Loading

luacmartins commented Nov 23, 2023 •

edited

Loading

luacmartins commented Nov 23, 2023 •

edited

Loading

aldo-expensify commented Nov 23, 2023 •

edited

Loading

luacmartins commented Nov 23, 2023 •

edited

Loading

aldo-expensify commented Dec 12, 2023 •

edited

Loading