[HOLD for checklist] [$1000] Android - Details - When entering numbers on each line, 3 dots will be displayed on the second line

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #21553

Action Performed:

1. Login to ND
2. Click on + icon and select Assign task option
3. Enter title and description(with multiple line ~30line)
4. Click on the Next button

Expected Result:

The information entered in the second line should be displayed correctly without 3 dots. All other apps don't show the 3 dots

Actual Result:

When entering numbers on each line, 3 dots will be displayed on the second line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.38.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

21553.Android.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f634e6d328dcb7fb
• Upwork Job ID: 1678879714211528704
• Last Price Increase: 2023-07-11

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

When the description is too long, we show ellipsis. This appears fine, doesn't it?

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android truncating the last character of the text before adding ....

What is the root cause of that problem?

The root cause of the issue is that the Text wrapped inside Flex View is not taking on the full width on Android when number of lines is restricted. This can be seen here.

What changes do you think we should make in order to solve the problem?

We just need to add flex: 1 here.

What alternative solutions did you explore? (Optional)

None

[Christinadobrzyn]

Looks like a dupe of - #21825 (comment) asking

[allroundexperts]

I don't think these are related but good to get more eyes here!

[Christinadobrzyn]

You're right @allroundexperts - not related!

I can only reproduce this on Android App:

adding external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f634e6d328dcb7fb

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[narefyev91]

Proposal from @allroundexperts looks good to me #22453 (comment)
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[srikarparsi]

Looks good to me as well, thanks @allroundexperts and @narefyev91!

[melvin-bot]

📣 @allroundexperts 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Christinadobrzyn]

@narefyev91 I'm not sure why you weren't automatically hired to this Upwork job but can you please send me your Upwork link so I can hire you as C+?

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.41-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: android truncating text incorrectly #22777

If no regressions arise, payment will be issued on 2023-07-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91 / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91 / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91 / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91 / @allroundexperts] Determine if we should create a regression test for this bug.
• [@narefyev91 / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

@allroundexperts is a on NewDot payment beta, @narefyev91 is Call Stack, and the issue reporter was Applause. So, no payments actually need to be made via Upwork here. 🎉

Just need the checklist completed @narefyev91!

FYI: Payment should be $1500 for standard payment + speed bonus of $500

[greg-schroeder]

Waiting for checklist

[greg-schroeder]

@narefyev91 / @allroundexperts can anyone take care of this checklist so we can close this out?

[allroundexperts]

Checklist

1. The issue existed since Tasks were implemented. As such, there isn't a particular PR to point to here.
2. N/A
3. Apart from more thorough PR testing, I don't think there is anything else we could have done here. Slack discussion is not required as additional checklist items are not needed here.
4. This was really hard to spot. I don't think it has any effect on the user experience. A regression test would be overkill here.

cc @greg-schroeder let me know if you disagree with the last point.

[greg-schroeder]

hmm. I think you're right. It seems a bit too niche to be added as a recurring test in this manner. Appreciate your help with the checklist :)

[JmillsExpensify]

Reviewed details for @allroundexperts. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.