Workspace - In Workspace, while inviting applausemail user, full id is not shown

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.85-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Launch app
2. Tap profile icon
3. Tap Workspaces
4. Tap on a workspace-- Members
5. Tap invite
6. Enter applausemail id [email protected]
7. Tap enter

Expected Result:

n Workspace, while inviting applausemail user, full id must be shown

Actual Result:

In Workspace, while inviting applausemail user, full id is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6240272_1697538100332.ener.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Nathan-Mulugeta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While inviting applausemail user, full id is not shown in workspace invite page,

What is the root cause of that problem?

The root cause of this problem is found here in this Text component:

App/src/components/SelectionList/UserListItem.js

Lines 25 to 30 in 9e1f190

	<Text
	style={[styles.optionDisplayName, isFocused ? styles.sidebarLinkActiveText : styles.sidebarLinkText, styles.sidebarLinkTextBold]}
	numberOfLines={1}
	>
	{item.text}
	</Text>

The problem is in the way how react native uses text break strategy for Android.

What changes do you think we should make in order to solve the problem?

We couldn't add styles.flex1 because of the direction of the flex for the container is set to column, therefore we can add styles.alignSelfStretch to the Text component. This will solve the problem.

  <Text
  style={[styles.optionDisplayName, isFocused ? styles.sidebarLinkActiveText : styles.sidebarLinkText, styles.sidebarLinkTextBold, styles.alignSelfStretch]}
                        numberOfLines={1}
                    >
                        {item.text}
                    </Text>

The result would look like this:

What alternative solutions did you explore? (Optional)

NA

[MitchExpensify]

I don't really understand this bug - The whole bug appears to show does it not? Or at least as much space as there is to show it @lanitochka17 ?

[Nathan-Mulugeta]

Hey @MitchExpensify ,

The problem we're facing is that when inviting a member with a long email, the search result doesn't display the full email address (i.e the display name defaulting to emails for users with an unrenamed display name), cutting it off prematurely as displayed here on the screen shot:

This issue has occurred in the past (referencing #23769 and #22453).

The root of the issue lies in how Android native handles line breaks when the number of lines is set to just one. It's more prominent on physical Android devices, I have tested this on Samsung physical devices, as opposed to Android simulators (pixel device simulator) where it's not as noticeable.

[MitchExpensify]

Ok got it, thanks for confirming! I do not think this is worth solving at this point tbh