[Hold #20841][$1000] IOS - Assign task - Multiline description is displayed as one line

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #21371

Action Performed:

1. Login to NewDot iOS app
2. Assign a task with multi-line description
3. Task chat is displayed

Expected Result:

There should be indication, that description has additional lines except first one, which are not displayed until you expand it

Actual Result:

Multiline description is displayed as one line (there is no any indication that there are any more line except for the first one)
Only iOS. Android has "..." and web shows all description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34.
1
Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6109883_IMG_1625.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cab68f81113415f5
• Upwork Job ID: 1674777522394394624
• Last Price Increase: 2023-06-30

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[manjesh-yadav]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task - Multiline description is displayed as one line

What is the root cause of that problem?

Here we are using MenuItemWithTopDescription component which is generally used for one-line or two-line headings that is why multiline descriptions are displayed as one line

What changes do you think we should make in order to solve the problem?

We should redesign our description text in src/components/TaskHeader.js and not change in MenuItemWithTopDescription as this component use many places

App/src/components/TaskHeader.js

Lines 128 to 135 in de9cec8

	<MenuItemWithTopDescription
	title={lodashGet(props.report, 'description', '')}
	description={props.translate('newTaskPage.description')}
	onPress={() => Navigation.navigate(ROUTES.getTaskReportDescriptionRoute(props.report.reportID))}
	disabled={!isOpen}
	interactive={isOpen}
	/>
	</View>

change this with the below initial design

<PressableWithFeedback
                onPress={() => Navigation.navigate(ROUTES.getTaskReportDescriptionRoute(props.report.reportID))}
                disabled={!isOpen}
                accessibilityRole="button"
            >
                    <View style={[styles.ph5, styles.pb5]}>
                        <Text
                            style={[styles.pre, styles.textLabelSupporting]}
                        >
                           {props.translate('newTaskPage.description')}
                        </Text>
                        <Text
                            style={[styles.headerText, styles.pre]}
                        >
                           {lodashGet(props.report, 'description', '')}
                        </Text>
                    </View>
            </PressableWithFeedback>

Result

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[sonialiap]

Reproducible, triaging to external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cab68f81113415f5

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[sonialiap]

@fedirjh we have a proposal above, could you take a look to see if we can move forward with it?

[fedirjh]

@sonialiap There is a refactor for the task detailed view in #20841 and I think it will fix this issue. Let's hold it until the PR is merged

[thienlnam]

Agreed with @fedirjh

[melvin-bot]

@sonialiap, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

Sounds good, adding hold to title

[Christinadobrzyn]

Hi @fedirjh @sonialiap would you be able to confirm if this issue is a dupe of this one? (I think so?)
#22453

[melvin-bot]

@sonialiap, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[fedirjh]

Hey @Christinadobrzyn, the issue appears to be similar, but it affects different pages. The one currently being addressed is the description within the task report, which will be fixed with #20841. However, the other issue pertains to the description within the create task modal, and it should be addressed separately since #20841 will not resolve it.

[fedirjh]

@sonialiap I believe we can consider this issue resolved and proceed with closing it. It has been fixed.

[sonialiap]

Sounds good, closing