[Tracker] Contact Method Flows Polish

[Beamanator]

Making this new issue to handle some follow-up tasks from #15751

We merged that PR with a few unresolved follow-ups because I wanted to unblock @cristipaval 's work with the Add New Contact Method flow

There's a few follow-ups issues we need to investigate, will mention them here as they should not be considered "bugs" in Slack (in the near future I'll create issues for them)

• We should definitely center the confirmation modal for removing a contact method
  • I just pulled main and couldn't reproduce, so I think we can call this good to go?
• Try to use the Form component for the Magic code input (& anywhere in the contact methods pages)
  • This should happen after we figure out exactly what the Offline UX should look like for that flow (trying to validate & resend magic code flows)
• Figure out best Offline UX flows for the 3 new flows recently added
  • Resend magic code
  • Validate a contact method
    • Currently there's not great feedback when offline
  • Delete a contact method
• Bug: Following platforms do not submit the verify magic code from on press of the done/tick button on the Virtual keyboard.
  • iOS Native, iOS Safari, Android Native.
• Passwordless - allow non-beta users to do the old password flows where needed :D
  • Actually maybe not, since passwords may go away in the next few weeks!
• Omit @expensify.sms everywhere possible (example)
• Limit magic code input to 6 digits (& only digits): https://expensify.slack.com/archives/C049HHMV9SM/p1680686551538709
• [HOLD for payment 2023-05-09] [$1000] Default contact method: Always show on top of "Contact methods" list #17883
  • Always show default contact method on top of "Contact methods" list
• Don't show green checkmark immediately when resending magic code, only once the code has successfully sent (so if it fails, we don't see "yay I sent / oh shit i didn't send" (reported here)
• [HOLD for payment 2023-07-20] Make secondary-login "Delete" always succeed, even if the login didn't exist before #20701
  • Source - cc @cristipaval
• Profile - Phone number duplicated when adding as a secondary contact #17722
• Setting a default contact method on two devices at the same time (similar report) (@cristipaval wants to work on this)
  • Basically instead of throwing "Already default contact method" error from the server, we should treat this as a "success" and send a pusher notification to the front-end as if this was a successful call (as long as this doesn't mess anything up in NewDot
• https://expensify.slack.com/archives/C049HHMV9SM/p1682416824226729
• Think about this case: If I change my default contact method, do my contacts need to be immediately aware of this change? Will anything in their app break? Or can they refresh and fix everything?
  • Also need to handle this case on other of the user's devices (updating personalDetails)
• Profile - Shouldn't be "reset password" in the error message #17974
• Make RBR consistent with the rest of the app in Contact Methods: Web - Profile - Error message disappears if user refresh the page a couple times #17827
  • Invalid number is automatically removed from the list on App closure #18252
• [HOLD E/E#280523] Update report actions when contact method is set as default #18575
• https://expensify.slack.com/archives/C049HHMV9SM/p1684833850028879
• Unable to delete a contact method including capital letters #19080
• https://github.com/Expensify/Expensify/issues/286059
• Make new Auth command for "Add new contact method" so it's 1:1:1

[Beamanator]

Keeping this as "planning" for now, as I need to figure out the desired offline UX patterns (part 3) before completing part 2.

[NikkiWines]

Just dropping in here to say that we should probably omit the @expensify.sms here

[Beamanator]

Still WIP - lots going on :D

[Beamanator]

Still in planning

[Beamanator]

Planning to keep this in "planning" until the "Set as default" App PR gets merged, as that's the final non-polish PR for Account Settings! (I believe)

[Beamanator]

Still working on getting the final "Set as default" App PR merged before moving forward on this list

[Beamanator]

@cristipaval assigning you here too since we're going to work on these polish issues together

[cristipaval]

Thank you!

[cristipaval]

Updated the title to help Melvin figure out that this one is on hold.

[Beamanator]

Still paused cuz we're hyper focused on wave 4 & 5

[Beamanator]

we'll definitely get back to these after offshore 🙏

[cristipaval]

We hope to settle down after the End of Offshore deadline and get back to this.

[cristipaval]

I would make this one Monthly, @Beamanator. I think detailed doc for the Onboarding flow has higher priority than this one.

[cristipaval]

thoughts about the above comment, @Beamanator ?

[Beamanator]

I agree! BTW you can make the change next time if you want :D

[Beamanator]

not prioritizing

[Beamanator]

same, not prioritizing

[cristipaval]

same

[cristipaval]

I'll look into this next week to see how many things still make sense.

[cristipaval]

I am going to close this one, given the urgency we have on waves. If anyone still thinks this has to be done, I think we have to go through the #whatsnext process