Profile - Shouldn't be "reset password" in the error message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the App
2. Login with any account
3. Go to Settings -> Profile -> Contact methods
4. Click on "New contact method" button
5. Add email/phone -> Tap Add button - repeat this 5-10 times until the limit error message appears

Expected Result:

Shouldn't be "reset password" in the error message since it is passwordless now

Actual Result:

The error message says "reset password"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.5.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6031742_Record_2023-04-25-17-02-32_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a8b769ba3a8ffb45
• Upwork Job ID: 1651597362130612224
• Last Price Increase: 2023-04-27

[MelvinBot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[isabelastisser]

I won't be able to review this today, and it was assigned to me yesterday; sorry that I don't have the capacity and need to reassign it. Thanks in advance to the other team member taking over this, I owe you one!

[MelvinBot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[JmillsExpensify]

@Beamanator I think this is an artifact of all accounts not being live with Passwordless yet, as I'm not able to reproduce this one. Does that sound right? All I can get is this error.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01a8b769ba3a8ffb45

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[Beamanator]

Hmm looks like we have that error message in the code here which doesn't look like it's set up for "Magic code" / passwordless, I think this is about being throttled so I'm going to try to reproduce now

[Beamanator]

Yep I was able to reproduce - this isn't for Magic code throttling, it's for Contact method throttling - so you have to add many contact methods (or fail many times and eventually you'll see this error)

[Beamanator]

So in this issue I'll actually fix two things in the error:

1. secondary login should read contact method
2. reset your password can be removed

[Beamanator]

Unassigning @mollfpr since this will be a server-side PR 👍

[JmillsExpensify]

Ok nice, thank you! Also going to improve the reproduction steps above. What is the limit where a contact method will be throttled?

[Beamanator]

GOooood question @JmillsExpensify - I think it's like 5 - 10 times, I didn't count very precisely 😬

[Beamanator]

PR went into production 4 days ago, closing