Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD E/E#280523] Update report actions when contact method is set as default #18575

Closed
Beamanator opened this issue May 8, 2023 · 13 comments
Closed
Assignees

Comments

@Beamanator
Copy link
Contributor

As mentioned in slack here, this PR has one slight problem: When a default contact method updates, we update the personalDetails onyx key fine but we don't update report actions

Right now report actions have personal details in them, and when a contact method is set as default, we don't update report actions. So if you don't have a display name set, when your new contact method is now default, your report actions won't show your new default contact method. Similarly, your contacts (people you've messaged) won't get the update until they refresh.

Now, this is not a huge problem because you can refresh the page to fix this. But it would be best if this could update live

We're going to keep this issue ON HOLD until https://github.com/Expensify/Expensify/issues/280523 moves forward, because in that project we plan to hide a lot of personal contact info in the App so you can't scrape it, and we'll re-key personal details by accountID. So this should help us solve this issue 👍

@Beamanator
Copy link
Contributor Author

still holding

@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 14, 2023
@Beamanator
Copy link
Contributor Author

still can't prioritize 😬

@melvin-bot melvin-bot bot removed the Overdue label Jul 19, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@Beamanator
Copy link
Contributor Author

Oof will get back to this in a bit

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@Beamanator
Copy link
Contributor Author

still on the list

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 27, 2023
@Beamanator
Copy link
Contributor Author

still useful, not priority yet

@melvin-bot melvin-bot bot removed the Overdue label Oct 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2023
@Beamanator
Copy link
Contributor Author

same

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
@Beamanator
Copy link
Contributor Author

same

@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2024
@Beamanator
Copy link
Contributor Author

@cristipaval i wonder if we should keep this one open 🤔

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@cristipaval
Copy link
Contributor

I feel like this thing needs a decent amount of effort to get it done for a small benefit that is indeed a nice thing to have, but the effort might bring more value if put on other priorities 🤷

@Beamanator
Copy link
Contributor Author

yeahhhhh i feel ya

@melvin-bot melvin-bot bot added the Overdue label Mar 14, 2024
@Beamanator
Copy link
Contributor Author

gunna postpone another month and see what happens 🤷

@melvin-bot melvin-bot bot removed the Overdue label Mar 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 18, 2024
@Beamanator
Copy link
Contributor Author

hmmmm

@melvin-bot melvin-bot bot removed the Overdue label Apr 19, 2024
@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@Beamanator
Copy link
Contributor Author

ok let's close this one for now since there's a bunch of other priorities still 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants