-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD E/E#280523] Update report actions when contact method is set as default #18575
Comments
still holding |
still can't prioritize 😬 |
Oof will get back to this in a bit |
still on the list |
still useful, not priority yet |
same |
same |
@cristipaval i wonder if we should keep this one open 🤔 |
I feel like this thing needs a decent amount of effort to get it done for a small benefit that is indeed a nice thing to have, but the effort might bring more value if put on other priorities 🤷 |
yeahhhhh i feel ya |
gunna postpone another month and see what happens 🤷 |
hmmmm |
ok let's close this one for now since there's a bunch of other priorities still 🙃 |
As mentioned in slack here, this PR has one slight problem: When a default contact method updates, we update the
personalDetails
onyx key fine but we don't update report actionsRight now report actions have personal details in them, and when a contact method is set as default, we don't update report actions. So if you don't have a display name set, when your new contact method is now default, your report actions won't show your new default contact method. Similarly, your contacts (people you've messaged) won't get the update until they refresh.
Now, this is not a huge problem because you can refresh the page to fix this. But it would be best if this could update live
We're going to keep this issue ON HOLD until https://github.com/Expensify/Expensify/issues/280523 moves forward, because in that project we plan to hide a lot of personal contact info in the App so you can't scrape it, and we'll re-key personal details by accountID. So this should help us solve this issue 👍
The text was updated successfully, but these errors were encountered: