[Tracking] Fix Composer Component Focus Issues

[bondydaa]

Proposal

There have been a few threads where these discussions happened (Expenisfy internal slack discussion) https://expensify.slack.com/archives/C03U7DCU4/p1673042523102459?thread_ts=1672788778.947399&cid=C03U7DCU4

and here in the external slack https://expensify.slack.com/archives/C01GTK53T8Q/p1671056016060879

I believe the final place we landed was

give focus back to the composer input AND allow the software keyboard to be shown at the same time

Ultimately what we want to do is stop trying to continually patch the existing code as we've sort of gotten into a bad spot with it. The goal of this is to start with a blank canvas and come up with a plan on how we want the composer component and the focus/blur interactions to work as if it didn't exist yet.

Once we have the overall design we desire we can then see how the current code fits with it, if it needs to be rewritten then we'll do that, if we can just tweak the existing code and get it to work then we can do that.

Tasks

• Post Proposal (full Problem/Solution statement) in #expensify-open-source
• Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
• Paste Proposal in the space above with a link to the Slack thread
• Email [email protected] and paste in the Proposal
• Fill out the High-level overview of the problem, Timeline, and Terminology sections of the Design Doc
• Email [email protected] (continue the same email chain as before) with the link to your Design Doc
• Host a pre-design meeting (example) in #expensify-open-source to discuss any necessary details in public before filling out the High-level of proposed solution section.
• Fill out the High-level of proposed solution section
• Email [email protected] again with links to the doc and pre-design conversation in Slack
• Add the DesignDocReview label to get the High-level of proposed solution section reviewed
• Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
• Confirm that the doc has the minimum necessary number of reviews before proceeding
• Host another pre-design meeting in #expensify-open-source to ask for engineering feedback on the technical solution.
• Fill out the Detailed implementation of the solution and related sections.
• Re-add the DesignDocReview label to this issue
• Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
• Confirm that the doc has the minimum necessary number of reviews before proceeding
• Email [email protected] one last time to let them know the Design Doc is moving into the implementation phase
• Implement the changes
• Send out a follow up email to [email protected] once everything has been implemented and do a Project Wrap-Up retrospective that provides:
  • Summary of what we accomplished with this project
  • What went well?
  • What could we have done better?
  • What did we learn?

Related Issues (Please add any new issues as they are reported) N.B. - closing some until this is picked up.

• Fix mWeb Compose Focus bug #14230
• [Hold][$1000] composer not focused when user return from new chat option after opening keyboard shortcuts #16362
• [HOLD on #15992] [$1000] Focus is not returned to the editor text field when a user opens settings sidebar and closes it #16844
• [Hold on #15992] Composer not focused when user leaves/returns an ongoing DM draft #16699
• [HOLD #15992][$1000] mWeb/Chrome - Chat - Android - keyboard opens when tapping outside of the edited message #16596
• [HOLD for payment 2023-08-24] [$1000] IOS - Chat - Focus is lost if user inserts emoji in edit mode using emoji picker #18001
• Search bar lost focus when LHN finish loading #17274
• App loses focus from compose box if we open the report user profile and then click on message user (works fine if we directly click on message user) #18007
• [HOLD for payment 2024-05-06] [HOLD #36071] [$1000] Textinput is not focused in chat after visiting conceirge help #21401
• [$1000] App loses focus from concierge compose box when visiting concierge chat after connect bank step 3 #22664
• [HOLD] [$1000] mWeb - mWeb - Keyboard opens automatically after going back from attachment #23489
• [HOLD for payment 2023-10-13] [$500] [Distance] - App does not refocus on address field on delete and cancel #27182
• [$500] Distance IOU - Address field is focused after tapping Cancel on Delete confirmation #28921
• https://github.com/Expensify/Expensify/issues/329380
• [$500] [MEDIUM] mWeb – Thread – Missing cursor when start a thread in the request preview of workspace chat. #30689

[MelvinBot]

Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MelvinBot]

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MelvinBot]

12 days overdue. Walking. Toward. The. Light...

[MelvinBot]

This issue has not been updated in over 14 days. eroding to Weekly issue.

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Natnael-Guchima]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

My bad, I mentioned this issue in the wrong place.

[MelvinBot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[Natnael-Guchima]

this might need to be tracked here #18007

[bondydaa]

feel free to edit and add them as you see fit, I don't need to be pinged or approve adding issues to this.

[sakluger]

Added #22664 to the list of related issues.

[tjferriss]

@bondydaa this issue also looks related #22949

[Beamanator]

Adding these two, very similar focus issues:

• [HOLD for payment 2023-10-13] [$500] [Distance] - App does not refocus on address field on delete and cancel #27182
• [$500] Distance IOU - Address field is focused after tapping Cancel on Delete confirmation #28921

[JmillsExpensify]

Adding this similar issue:

• [$500] mWeb - Request money - Composer doesn't get focused when coming back with back button from receipt page #28139

[abekkala]

• [$500] The main composer in the request report page is focused when closing the three dot menu #30178

[conorpendergrast]

Adding #30689

[melvin-bot]

@bondydaa, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[abekkala]

@bondydaa should this one remained open?

[bondydaa]

I'm not sure it needs to. it's super old and I believe Monil had already implemented a doc to fix most of this so probably anything that might still be a problem can be spun up as a new issue and follow the current BZ flow.

…

On Mon, Feb 5, 2024 at 12:58 PM April Bekkala ***@***.***> wrote: @bondydaa <https://github.com/bondydaa> should this one remained open? — Reply to this email directly, view it on GitHub <#15992 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7CPCWZR3W2EZ2AF3VVZI3YSE2VHAVCNFSM6AAAAAAV37WQNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXHE4TMNJYHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>