-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold - #15992] All message boxes lose focusing when clicking on Report a bug link #26353
Comments
Triggered auto assignment to @NicMendonca ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.All message boxes lose focusing when clicking on Report a bug link What is the root cause of that problem?When click on Report a bug the app navigate to the App/src/libs/actions/Report.js Line 1312 in c20c387
But there’s no explicit focus management after navigation, so focus is not automatically set to a specific field unless specified. What changes do you think we should make in order to solve the problem?One approach is that add explicit focus management after navigation. useEffect(() => {
if (shouldFocusInputOnScreenFocus && shouldShowComposeInput) {
focus();
}
}, [shouldFocusInputOnScreenFocus, shouldShowComposeInput]); What alternative solutions did you explore? (Optional) |
Same root cause with #21401 |
Hey @NicMendonca Yes it has the same root cause and should be put on hold for #15992 |
@NicMendonca Whoops! This issue is 2 days overdue. Let's get this updated quick! |
still holding |
^^ |
#15992 is monthly, so moving this to monthly |
^^ waiting on #15992 |
I'm going to close this for now because its so old. #15992 is still open |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
All message boxes should not lose focusing when clicking on Report a bug link
Actual Result:
All message boxes lose focusing when clicking on Report a bug link
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen-Capture.57.mp4
Recording.1395.mp4
Expensify/Expensify Issue URL:
Issue reported by: @MahmudjonToraqulov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692593482423179
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: