Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold - #15992] All message boxes lose focusing when clicking on Report a bug link #26353

Closed
1 of 6 tasks
izarutskaya opened this issue Aug 30, 2023 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open website > Settings > About > Click on Report a bug

Expected Result:

All message boxes should not lose focusing when clicking on Report a bug link

Actual Result:

All message boxes lose focusing when clicking on Report a bug link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.59-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen-Capture.57.mp4
Recording.1395.mp4

Expensify/Expensify Issue URL:

Issue reported by: @MahmudjonToraqulov

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692593482423179

View all open jobs on GitHub

@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@alphaboss1104
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

All message boxes lose focusing when clicking on Report a bug link

What is the root cause of that problem?

When click on Report a bug the app navigate to the Concierge chat page.

Navigation.navigate(ROUTES.getReportRoute(conciergeChatReportID));

But there’s no explicit focus management after navigation, so focus is not automatically set to a specific field unless specified.
This is the root cause of this issue.

What changes do you think we should make in order to solve the problem?

One approach is that add explicit focus management after navigation.
We can achieve this by using the useEffect hook in the ReportActionCompose.js to set the focus to the compose input when the component is mounted. This will ensure the compose input gets focus after navigation.

    useEffect(() => {
        if (shouldFocusInputOnScreenFocus && shouldShowComposeInput) {
            focus();
        }
    }, [shouldFocusInputOnScreenFocus, shouldShowComposeInput]);

What alternative solutions did you explore? (Optional)

@bernhardoj
Copy link
Contributor

Same root cause with #21401

@NicMendonca
Copy link
Contributor

@fedirjh do you think this is the same root cause of #21401?

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@fedirjh
Copy link
Contributor

fedirjh commented Sep 4, 2023

Hey @NicMendonca Yes it has the same root cause and should be put on hold for #15992

@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@NicMendonca Whoops! This issue is 2 days overdue. Let's get this updated quick!

@NicMendonca NicMendonca changed the title All message boxes lose focusing when clicking on Report a bug link [Hold - #15992] All message boxes lose focusing when clicking on Report a bug link Sep 5, 2023
@NicMendonca NicMendonca added Weekly KSv2 and removed Daily KSv2 labels Sep 5, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 14, 2023
@NicMendonca
Copy link
Contributor

still holding

@melvin-bot melvin-bot bot removed the Overdue label Sep 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2023
@NicMendonca
Copy link
Contributor

^^

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@NicMendonca NicMendonca added Monthly KSv2 and removed Weekly KSv2 labels Oct 5, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 5, 2023
@NicMendonca
Copy link
Contributor

#15992 is monthly, so moving this to monthly

@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@NicMendonca
Copy link
Contributor

^^ waiting on #15992

@melvin-bot melvin-bot bot removed the Overdue label Nov 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
@NicMendonca
Copy link
Contributor

I'm going to close this for now because its so old. #15992 is still open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants