[HOLD for payment 2024-06-20] [$1000] IOS- Screen flickering on tapping delete(Transition not smooth)

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #24071

Action Performed:

1. Request money from another user
2. Tap the report preview (this will navigate you to the iou report)
3. Hover the IOU preview and tap the thrash can icon
4. Verify that a modal confirming if you want to delete the request shows up
5. Tap Cancel and verify that the modal closes
6. Repeat step 1-4 but this time tap Delete
7. Verify that the request is deleted
8. Request money again
9. Tap the report preview (this will navigate you to the iou report)
10. Tap the IOU preview (this will navigate you to the transaction thread report)
11. Tap the three dot menu at the top right of the page and then Delete request
12. Verify that the same confirmation modal shows up
13. Tap Cancel and verify that the modal closes
14. Tap the three dot menu at the top right of the page and then Delete request again

Expected Result:

Delete request confirmation modal displayed without any issues

Actual Result:

Screen flickering on tapping delete(Transition not smooth)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.53.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6161591_RPReplay_Final1691777346.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019298424ebc35a6e6
• Upwork Job ID: 1696029632941596672
• Last Price Increase: 2023-10-02
• Automatic offers:
• 0xmiroslav | Reviewer | 27008615
• ntdiary | Contributor | 27008616
• getusha | Contributor | 0

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

I think this can be handled in #13922

[sophiepintoraetz]

Sounds good - closing this for now.

[bernhardoj]

@sophiepintoraetz looks like it won't be handled in #13922. I think we can keep this open for now.

[melvin-bot]

@sophiepintoraetz Eep! 4 days overdue now. Issues have feelings too...

[sophiepintoraetz]

I need to find the time to reproduce this!

[melvin-bot]

@sophiepintoraetz this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@sophiepintoraetz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sophiepintoraetz]

Today!

[sophiepintoraetz]

Yup - I'm able to reproduce

RPReplay_Final1693199628.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019298424ebc35a6e6

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• enable new focus management for waypoint and report field page #43041

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment automatic offer (Contributor)
• @getusha requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

@getusha please complete the checklist!

[kadiealexander]

Payouts due:

• Contributor: $1000 @ntdiary - https://www.upwork.com/nx/wm/offer/27008616
• Contributor+: $1000 @getusha - https://www.upwork.com/nx/wm/offer/103274633

[melvin-bot]

@ntdiary, @Julesssss, @kadiealexander, @getusha Huh... This is 4 days overdue. Who can take care of this?

[Julesssss]

Hey @kadiealexander is this completed?

[kadiealexander]

@getusha still needs to complete the BugZero checklist so I can pay out.

[Julesssss]

Waiting on @getusha

[getusha]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR: N/a This is an edge case and i don't think there is a specific PR that's responsible for this issue
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. Yes
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Submit an expense to another user
2. Press the expense preview to open the request details page
3. Focus the main composer input
4. Press the three dot menu at the top right of the page
5. Press the Delete expense
6. Verify the confirmation modal is opened smoothly and the keyboard didn't flicker

Do we agree 👍 or 👎

[Julesssss]

Sorry @getusha I should have said earlier, but I don't think we need a specific regression test for this flickering.

[getusha]

Sorry @getusha I should have said earlier, but I don't think we need a specific regression test for this flickering.

we can skip it since we had this issue happening several places. my reasoning was to just have one simpler test case to ensure it gets caught if any changes are made to the new focus manager.

[getusha]

@kadiealexander friendly bump for payment on this one, i am not able to find the offer :)

[kadiealexander]

Hey @getusha is this offer visible for you? https://www.upwork.com/nx/wm/offer/103274633

[kadiealexander]

@getusha bump!

[getusha]

@kadiealexander accepted the offer, thank you!