enable new focus management for waypoint and report field page #43041

ntdiary · 2024-06-04T15:59:34Z

Details

Fixed Issues

Tests

case1:
waypoint edit page - delete confirmation modal

Open a workspace report.
Try to submit a distance expense and select three waypoints.
Select one of them and click the three dot menu button to open the delete confirmation modal.
Verify there is no keyboard flicker.
Click the Delete button and verify there is no keyboard flicker again.

case2:
customizing report field - delete confirmation modal ( reportFields beta feature)
Precondition:
A paid workspace and two account ( admin A and member B).

As admin A, login to OD
Select Settings => Workspaces => the paid workspace => Reports sub option
Add some customizing text report fields
As member B, login to ND and submit an expense in this paid workspace
As admin A, delete one of report fields.
As member B, open the expense report in the paid workspace.
Select the deleted report filed to open the edit page.
Click the three dot menu button to open the delete confirmation modal.
Verify there is no keyboard flicker.

Verify that no errors appear in the JS console

Offline tests

QA Steps

case1:
waypoint edit page - delete confirmation modal

Open a workspace report.
Try to submit a distance expense and select three waypoints.
Select one of them and click the three dot menu button to open the delete confirmation modal.
Verify there is no keyboard flicker.
Click the Delete button and verify there is no keyboard flicker again.

case2:
customizing report field - delete confirmation modal (beta feature)
Precondition:
A paid workspace and two account ( admin A and member B).

As admin A, login to OD
Select Settings => Workspaces => the paid workspace => Reports sub option
Add some customizing text report fields
As member B, login to ND and submit an expense in this paid workspace
As admin A, delete one of report fields.
As member B, open the expense report in the paid workspace.
Select the deleted report filed to open the edit page.
Click the three dot menu button to open the delete confirmation modal.
Verify there is no keyboard flicker.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

43041-1-android-native.mp4

43041-2-android-native.mp4

Android: mWeb Chrome

43041-1-android-chrome.mp4

43041-2-android-chrome.mp4

iOS: Native

43041-1-ios-native.mp4

43041-2-ios-native.mp4

iOS: mWeb Safari

43041-1-ios-safari.mp4

43041-2-ios-safari.mp4

MacOS: Chrome / Safari

43041-web.mp4

MacOS: Desktop

43041-desktop.mp4

melvin-bot · 2024-06-05T15:51:03Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2024-06-06T15:39:52Z

@getusha , friendly bump for review. 😄

getusha · 2024-06-07T08:07:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Case 1:

Screen.Recording.2024-06-07.at.1.01.47.in.the.afternoon.mov

Case 2:

Screen.Recording.2024-06-07.at.1.02.33.in.the.afternoon.mov

Android: mWeb Chrome

Case 1:

Screen.Recording.2024-06-07.at.12.08.15.in.the.afternoon.mov

Case 2:

Screen.Recording.2024-06-07.at.12.09.40.in.the.afternoon.mov

iOS: Native

Case 1:

Screen.Recording.2024-06-07.at.12.57.46.in.the.afternoon.mov

Case 2:

Screen.Recording.2024-06-07.at.12.58.48.in.the.afternoon.mov

iOS: mWeb Safari

Case 1:

Screen.Recording.2024-06-07.at.12.03.11.in.the.afternoon.mov

Case 2:

Screen.Recording.2024-06-07.at.12.04.38.in.the.afternoon.mov

MacOS: Chrome / Safari

Case 1:

Screen.Recording.2024-06-07.at.11.21.30.in.the.morning.mov

Case 2:

Screen.Recording.2024-06-07.at.11.59.38.in.the.morning.mov

MacOS: Desktop

Screen.Recording.2024-06-07.at.1.07.19.in.the.afternoon.mov

getusha

lgtm & tests well!

ntdiary · 2024-06-07T11:44:23Z

src/pages/iou/request/step/IOURequestStepWaypoint.tsx

@@ -186,6 +192,8 @@ function IOURequestStepWaypoint({
                    confirmText={translate('common.delete')}
                    cancelText={translate('common.cancel')}
                    danger
+                    shouldEnableNewFocusManagement


a bit strange, I thought there would be a conflict with the main branch here. 🤔

Lol, you jynxed us -- #43261

Julesssss · 2024-06-07T12:18:02Z

@ntdiary it looks like there is a dupe line that wasn't a git conflict (error)

/home/runner/work/App/App/src/pages/iou/request/step/IOURequestStepWaypoint.tsx
Error:   196:21  error  No duplicate props allowed  react/jsx-no-duplicate-props

Julesssss · 2024-06-07T12:19:07Z

I'll fix it 👍

Julesssss · 2024-06-07T12:21:47Z

@ntdiary no need to test, but could you just review this PR please: #43269

OSBotify · 2024-06-11T23:34:37Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ntdiary added 3 commits June 4, 2024 23:55

enable new focus management

5d107e0

do not refocus after deletion

6ffb67a

fix ts check

55e84c0

ntdiary marked this pull request as ready for review June 5, 2024 15:50

ntdiary requested a review from a team as a code owner June 5, 2024 15:50

melvin-bot bot requested review from getusha and removed request for a team June 5, 2024 15:51

ntdiary mentioned this pull request Jun 6, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] [$250] Distance - Unable to remove stop from the route #43112

Closed

6 tasks

getusha approved these changes Jun 7, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss June 7, 2024 10:11

Julesssss approved these changes Jun 7, 2024

View reviewed changes

Julesssss merged commit 0460aec into Expensify:main Jun 7, 2024
18 of 19 checks passed

ntdiary commented Jun 7, 2024

View reviewed changes

github-actions bot mentioned this pull request Jun 10, 2024

Deploy Checklist: New Expensify 2024-06-10 #43344

Closed

lanitochka17 mentioned this pull request Jun 11, 2024

[HOLD for payment 2024-06-28] [$250] Expense report - Delete modal does not disappear immediately after deleting report field #43496

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 11, 2024

[HOLD for payment 2024-06-20] [$1000] IOS- Screen flickering on tapping delete(Transition not smooth) #24452

Closed

6 tasks

sonialiap mentioned this pull request Jun 18, 2024

[$500] Request money - Distance - Keyboard is showing for brief moment of time while coming from delete waypoint #27201

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable new focus management for waypoint and report field page #43041

enable new focus management for waypoint and report field page #43041

ntdiary commented Jun 4, 2024 •

edited

Loading

melvin-bot bot commented Jun 5, 2024

ntdiary commented Jun 6, 2024

getusha commented Jun 7, 2024 •

edited

Loading

getusha left a comment

ntdiary Jun 7, 2024

Julesssss Jun 7, 2024

Julesssss commented Jun 7, 2024

Julesssss commented Jun 7, 2024

Julesssss commented Jun 7, 2024

OSBotify commented Jun 11, 2024

enable new focus management for waypoint and report field page #43041

enable new focus management for waypoint and report field page #43041

Conversation

ntdiary commented Jun 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 5, 2024

ntdiary commented Jun 6, 2024

getusha commented Jun 7, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha left a comment

Choose a reason for hiding this comment

ntdiary Jun 7, 2024

Choose a reason for hiding this comment

Julesssss Jun 7, 2024

Choose a reason for hiding this comment

Julesssss commented Jun 7, 2024

Julesssss commented Jun 7, 2024

Julesssss commented Jun 7, 2024

OSBotify commented Jun 11, 2024

ntdiary commented Jun 4, 2024 •

edited

Loading

getusha commented Jun 7, 2024 •

edited

Loading