Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failures with leaflet 1.1.0 #967

Closed
jgravois opened this issue Jul 3, 2017 · 0 comments · Fixed by #1025
Closed

test failures with leaflet 1.1.0 #967

jgravois opened this issue Jul 3, 2017 · 0 comments · Fixed by #1025
Assignees
Milestone

Comments

@jgravois
Copy link
Contributor

jgravois commented Jul 3, 2017

https://travis-ci.org/Esri/esri-leaflet/builds/243458201

we're seeing a handful of different failures, but they all result from FeatureLayer.createFeatures() not being called. manual testing confirms they are false positives, but i haven't been able to figure out why the spies aren't being triggered.

typically rogue errors like this are caused by the fact that the actual requests don't look enough like the urls sinon.fakeServer is poised to send responses for.

with this in mind, i tried substituting an overly generic regex, but found no joy.

server.respondWith('GET', new RegExp(/http:\/\/gis.example.com\/mock\/arcgis\/rest\/services\/MockService\/MockFeatureServer\/0\/query\?.+/), JSON.stringify({
    fields: fields,
    features: [feature1, feature2],
    objectIdFieldName: 'OBJECTID'
}));
@jgravois jgravois added this to the 2.0 9 milestone Jul 10, 2017
jgravois added a commit to jgravois/esri-leaflet that referenced this issue Jul 17, 2017
even though the plugin IS compatiable with Leaflet 1.1.0, our test suite is currently throwing false positive errors.

this manual lock will allow us to review pending PRs and tag a new release of our own and save investigating Esri#967 for later.
jgravois added a commit to jgravois/esri-leaflet that referenced this issue Jul 17, 2017
even though the plugin IS compatiable with Leaflet 1.1.0, our test suite is currently throwing false positive errors.

this manual lock will allow us to review pending PRs and tag a new release of our own and save investigating Esri#967 for later.
@jgravois jgravois self-assigned this Jul 28, 2017
jgravois added a commit that referenced this issue Nov 22, 2017
resolves #907 (by omission)

i've long been unable to figure out how to migrate successfully to phantomjs 2.x
without breaking a significant number of tests.

on the contrary, only one real test was sacrificed to take this approach.
the added benefit is that it also resolves #967
jgravois added a commit that referenced this issue Nov 22, 2017
resolves #907 (by omission)

i've long been unable to figure out how to migrate successfully to phantomjs 2.x
without breaking a significant number of tests.

on the contrary, only one real test was sacrificed to take this approach.
the added benefit is that it also resolves #967
jgravois added a commit to jgravois/esri-leaflet that referenced this issue Apr 23, 2022
even though the plugin IS compatiable with Leaflet 1.1.0, our test suite is currently throwing false positive errors.

this manual lock will allow us to review pending PRs and tag a new release of our own and save investigating Esri#967 for later.
jgravois added a commit to jgravois/esri-leaflet that referenced this issue Apr 23, 2022
resolves Esri#907 (by omission)

i've long been unable to figure out how to migrate successfully to phantomjs 2.x
without breaking a significant number of tests.

on the contrary, only one real test was sacrificed to take this approach.
the added benefit is that it also resolves Esri#967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant