-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test failures with leaflet 1.1.0 #967
Milestone
Comments
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this issue
Jul 17, 2017
even though the plugin IS compatiable with Leaflet 1.1.0, our test suite is currently throwing false positive errors. this manual lock will allow us to review pending PRs and tag a new release of our own and save investigating Esri#967 for later.
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this issue
Jul 17, 2017
even though the plugin IS compatiable with Leaflet 1.1.0, our test suite is currently throwing false positive errors. this manual lock will allow us to review pending PRs and tag a new release of our own and save investigating Esri#967 for later.
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this issue
Apr 23, 2022
even though the plugin IS compatiable with Leaflet 1.1.0, our test suite is currently throwing false positive errors. this manual lock will allow us to review pending PRs and tag a new release of our own and save investigating Esri#967 for later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://travis-ci.org/Esri/esri-leaflet/builds/243458201
we're seeing a handful of different failures, but they all result from
FeatureLayer.createFeatures()
not being called. manual testing confirms they are false positives, but i haven't been able to figure out why the spies aren't being triggered.typically rogue errors like this are caused by the fact that the actual requests don't look enough like the urls sinon.fakeServer is poised to send responses for.
with this in mind, i tried substituting an overly generic regex, but found no joy.
The text was updated successfully, but these errors were encountered: