Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNMET PEER DEPENDENCY in [email protected] with [email protected] #995

Closed
mush opened this issue Aug 14, 2017 · 3 comments
Closed

UNMET PEER DEPENDENCY in [email protected] with [email protected] #995

mush opened this issue Aug 14, 2017 · 3 comments

Comments

@mush
Copy link

mush commented Aug 14, 2017

  • Version of Leaflet (L.version):

1.1.0

  • Version of esri Leaflet (L.esri.VERSION):

2.1.1

Steps to reproduce the error:
Setup the a basic project with webpack and run npm install.

What happens is,
I see the following message:

├─┬ [email protected] 
│ ├── [email protected] 
│ ├── [email protected] 
│ └── [email protected] 
└── UNMET PEER DEPENDENCY [email protected]

I was expecting,
There shouldn't be UNMET PEER DEPENDENCY.

  • I'm not using the CDN, I'm loading/bundling the library using:

webpack

@mush
Copy link
Author

mush commented Aug 14, 2017

This,

"peerDependencies": {
    "leaflet": ">= 1.0.0 < 2"
  }

should fix the issue.

@jgravois
Copy link
Contributor

hi @mush. thanks for the report. at the moment this is expected behavior.

i made a conscious decision in #974 to temporarily cap the version of Leaflet we use internally at v1.0.x because of the false-positive CI test errors i documented in #967.

no one has reported any real compatibility bugs with Leaflet v1.1.0 or v1.2.0 (yet anyway) so you're welcome to use the latest and greatest, but until i figure out how to fix our test suite, if you do you're just going to have to live with the warning.

@mush
Copy link
Author

mush commented Aug 14, 2017

Thanks @jgravois.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants