Fix problem with fetching AGS layers in polar #971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fix proposed in Leaflet/Leaflet#5617 for correctly located AGS maplayers on polar stereographic projections.
|
thanks for this! i have my hands full at UC this week, but i'll make time to review your patch fully soon. |
|
Fixed a bunch of style errors |
|
The integration is failing tests, but doesnt seem to be anything to do with this fix. As far as we can see, the same failures in FeatureManager are present in the master branch. The changes pass the DynamicMapLayer Tests |
|
no doubt. the errors are from #967. I'll pull down your branch and verify locally soon. |
|
thanks for your patience. now that i'm back in the office i've reviewed your patch and it looked great!
i DRYed up the logic for the benefit of thank you so much for taking the time to make this contribution! its really a cool one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix proposed in Leaflet/Leaflet#5617 for correctly located AGS maplayers on polar stereographic projections.