fix(combobox): add space after grouped items #7302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
Elijbet
added
the
pr ready for visual snapshots
Elijbet
added
pr ready for visual snapshots
driskull
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
This looks good. Should ancestors be marked as @internal in doc? We don't want or need users to set ancestors right? cc @geospatialem @jcfranco
packages/calcite-components/src/components/combobox-item-group/combobox-item-group.tsx
Outdated
Show resolved
Hide resolved
anveshmekala
approved these changes
Jul 10, 2023
packages/calcite-components/src/components/combobox-item-group/combobox-item-group.scss
Outdated
Show resolved
Hide resolved
Yes, it should be internal. Nice catch. Let's do this separately to confirm that using |
jcfranco
approved these changes
Jul 10, 2023
packages/calcite-components/src/components/combobox-item-group/combobox-item-group.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/combobox-item-group/combobox-item-group.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/combobox/combobox.stories.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/combobox/combobox.stories.ts
Outdated
Show resolved
Hide resolved
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Elijbet
removed
Stale
jcfranco
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Awesome!
👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾
👾👩🚀👩🚀👩🚀👩🚀👾👩🚀👾👾👾👾👾👩🚀👾👩🚀👩🚀👩🚀👩🚀👾👾👩🚀👩🚀👩🚀👾👾👩🚀👩🚀👾👾👩🚀👾👾👾👩🚀👾👩🚀👩🚀👩🚀👩🚀👾
👾👩🚀👾👾👩🚀👾👩🚀👾👾👾👾👾👩🚀👾👩🚀👾👾👾👾👩🚀👾👾👾👾👩🚀👾👾👩🚀👾👩🚀👩🚀👾👩🚀👩🚀👾👩🚀👾👾👾👾
👾👩🚀👩🚀👩🚀👩🚀👾👩🚀👾👾👩🚀👾👾👩🚀👾👩🚀👩🚀👩🚀👾👾👾👩🚀👩🚀👾👾👩🚀👾👾👩🚀👾👩🚀👾👩🚀👾👩🚀👾👩🚀👩🚀👩🚀👾👾
👾👩🚀👾👾👩🚀👾👩🚀👾👩🚀👾👩🚀👾👩🚀👾👩🚀👾👾👾👾👾👾👾👩🚀👾👩🚀👾👾👩🚀👾👩🚀👾👾👾👩🚀👾👩🚀👾👾👾👾
👾👩🚀👾👾👩🚀👾👾👩🚀👾👾👾👩🚀👾👾👩🚀👩🚀👩🚀👩🚀👾👩🚀👩🚀👩🚀👾👾👾👩🚀👩🚀👾👾👩🚀👾👾👾👩🚀👾👩🚀👩🚀👩🚀👩🚀👾
👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾
packages/calcite-components/src/components/combobox-item-group/combobox-item-group.tsx
Outdated
Show resolved
Hide resolved
…fter-grouped-items
… codebase setup, target CSS.groupThatFollowsChildlessGroup directly instead and rework the solution to be able to override that one group
…fter-grouped-items
Elijbet
added
the
pr ready for visual snapshots
jcfranco
approved these changes
Aug 3, 2023
packages/calcite-components/src/components/combobox/combobox.tsx
Outdated
Show resolved
Hide resolved
jcfranco
changed the title
Elijbet
added
pr ready for visual snapshots
jcfranco
reviewed
Aug 3, 2023
packages/calcite-components/src/components/combobox/combobox.stories.ts
Outdated
Show resolved
Hide resolved
benelan
deleted the
elijbet/6412-combobox-item-group-add-space-after-grouped-items
branch
Merged
benelan
added a commit
that referenced
this pull request
Aug 3, 2023
* origin/main: (40 commits) fix(combobox): add space after grouped items (#7302) fix(tooltip): emits `close` and `beforeClose` events when container is set to `display:none` (#7258) chore: release next feat(block): improve block's content layout to allow scrolling (#7367) test(input, input-number): await on missed `page.waitForChanges` calls (#7429) chore: release next fix(color-picker): draw slider thumbs within bounds (#7398) chore: release next fix(slider): prevent excessive tick rendering (#7421) fix(tooltip): avoid extra before open/close event emitting (#7422) chore(storybook): hide warning and show TestOnly stories in local builds (#7424) chore: release next fix(panel): Remove double border styling when content isn't provided (#7368) feat(list): Add support for dragging items. (#7109) chore: release next fix(scrim): update loader scale on resize of component. (#7419) feat(text-area): provide additional context for AT users when character limit exceeds (#7412) chore: release next fix(chip): disconnect mutation observer when component is disconnected from the DOM (#7418) fix(switch): Fix for focus outline style in certain cases (#7414) ...
benelan
pushed a commit
that referenced
this pull request
Aug 3, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.5.0</summary> ## [1.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-03) ### Features * **action-group:** Adds overlayPositioning property. ([#7366](#7366)) ([ca9f35a](ca9f35a)) * Allow sharing focus trap stacks via configuration global ([#7334](#7334)) ([934a19f](934a19f)) * Automatically import and define Calcite Components when importing their React wrapper ([#7185](#7185)) ([bf0ff67](bf0ff67)) * **block, block-section:** Add setFocus method ([#7208](#7208)) ([35d4bbb](35d4bbb)) * **block:** Improve block's content layout to allow scrolling ([#7367](#7367)) ([ecbf17b](ecbf17b)) * **color-picker:** Replaces thumb focus outline to rounded ([#7378](#7378)) ([d803980](d803980)) * **filter:** Add filter method ([#7127](#7127)) ([5a4283f](5a4283f)) * **flow:** Adds setFocus method ([#7252](#7252)) ([2472c58](2472c58)) * Improve focus behavior in components ([#7277](#7277)) ([ad9fbca](ad9fbca)) * **input-time-zone:** Add input-time-zone component ([#6947](#6947)) ([87bd496](87bd496)) * **list:** Add slots for filter actions ([#7183](#7183)) ([da07ab1](da07ab1)) * **list:** Add support for dragging items. ([#7109](#7109)) ([7324f70](7324f70)) * **menu-item:** Update spacing and icon layout ([#7381](#7381)) ([5659671](5659671)) * **navigation-logo:** Increase font-size of heading with no description ([#7081](#7081)) ([355e101](355e101)) * **switch:** Updates focus outline to be rounded ([#7390](#7390)) ([2616b82](2616b82)) * **text-area:** Provide additional context for AT users when character limit exceeds ([#7299](#7299)) ([c5678eb](c5678eb)) * **text-area:** Provide additional context for AT users when character limit exceeds ([#7412](#7412)) ([c1af3c7](c1af3c7)) ### Bug Fixes * **accordion, accordion-item:** `icon-position`, `icon-type`, `selection-mode` and `scale` can now be set as props or attributes ([#7191](#7191)) ([2b09aba](2b09aba)) * **action-bar:** No longer delegates focus when clicked on non-focusable region ([#7310](#7310)) ([1a9c15c](1a9c15c)) * **action:** Correctly focus the button after rendering updates. ([#7255](#7255)) ([40fe2ce](40fe2ce)) * **block:** Loader now appears for all loading cases ([#7303](#7303)) ([5af3600](5af3600)) * **block:** Removes extra loading indicator ([#7239](#7239)) ([a334a75](a334a75)) * **card:** Ensure teardown logic is called when disconnected ([#7289](#7289)) ([d07e322](d07e322)) * **chip:** Disconnect mutation observer when component is disconnected from the DOM ([#7418](#7418)) ([412e5fb](412e5fb)) * **color-picker:** Draw slider thumbs within bounds ([#7398](#7398)) ([2f37854](2f37854)) * **color-picker:** Fix opacity slider keyboard nudging ([#7400](#7400)) ([2b4f7c3](2b4f7c3)) * **color-picker:** Maintains correct numbering system when entering invalid RGB value ([#7327](#7327)) ([8d2a3a5](8d2a3a5)) * **combobox:** Add space after grouped items ([#7302](#7302)) ([b1580c7](b1580c7)) * **dropdown-item:** Provides accessible label when href is not parsed ([#7316](#7316)) ([966b83d](966b83d)) * **flow:** Call setFocus() on back button click ([#7285](#7285)) ([9102aa4](9102aa4)) * **input-date-picker:** Provides placeholder text context for AT users ([#7320](#7320)) ([31e0ba2](31e0ba2)) * **input-date-picker:** Reset active date picker date after closing ([#7219](#7219)) ([91b2a1b](91b2a1b)) * **input, input-number:** No longer removes trailing decimal separator ([#7159](#7159)) ([01535cf](01535cf)) * **link:** Adds outline-offset to avoid overlapping with text. ([#7342](#7342)) ([c30db4e](c30db4e)) * **list:** Changing filterText property will now update filtered items ([#7133](#7133)) ([a9c0bce](a9c0bce)) * **list:** Fix keyboard navigation after a listItem's disabled or closed property changes ([#7275](#7275)) ([91d28eb](91d28eb)) * **list:** Fix keyboard navigation when filterEnabled is true ([#7385](#7385)) ([41a2e42](41a2e42)) * **menu-item:** Prevent duplicate border in nested vertical menu-items ([#7387](#7387)) ([186a738](186a738)) * **panel:** Remove double border styling when content isn't provided ([#7368](#7368)) ([91a0610](91a0610)) * Remove style modifying all host components with hidden attribute ([#7346](#7346)) ([3103e2f](3103e2f)) * **scrim:** Update loader scale on resize of component. ([#7419](#7419)) ([24e7f70](24e7f70)) * **slider:** Prevent excessive tick rendering ([#7421](#7421)) ([c799409](c799409)) * **switch:** Fix for focus outline style in certain cases ([#7414](#7414)) ([217324f](217324f)) * **tab-title:** Add full focus outline to closable tab button in high contrast mode ([#7272](#7272)) ([d812d17](d812d17)) * **tooltip:** Avoid extra before open/close event emitting ([#7422](#7422)) ([dbb6818](dbb6818)) * **tooltip:** Deprecate the label property due to the description coming from the component's content ([#7247](#7247)) ([7934d75](7934d75)) * **tooltip:** Emits `close` and `beforeClose` events when container is set to `display:none` ([#7258](#7258)) ([60a4683](60a4683)) * **tooltip:** Ensure --calcite-app-z-index-tooltip is applied ([#7345](#7345)) ([a9a7072](a9a7072)) </details> <details><summary>@esri/calcite-components-react: 1.5.0</summary> ## [1.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-03) ### Features * Automatically import and define Calcite Components when importing their React wrapper ([#7185](#7185)) ([bf0ff67](bf0ff67)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.5.0-next.38 to ^1.5.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6412
Summary
Adding space at the bottom of grouped items to provide visual separation between the group and any following content.