Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox Item Group - add space after grouped items #6412

Closed
ashetland opened this issue Feb 1, 2023 · 4 comments
Closed

Combobox Item Group - add space after grouped items #6412

ashetland opened this issue Feb 1, 2023 · 4 comments
Assignees
@geospatialem @SkyeSeitz @ashetland @brittneytewks
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Urban Issues logged by ArcGIS Urban team members. c-combobox Issues that pertain to the calcite-combobox and related components Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Milestone
2023 July Priorities

Comments

@ashetland
Copy link
Contributor

Description

It is currently very difficult to know where a combobox-item-group ends. Adding space at the bottom of grouped items will provide visual separation between the group and any following content.

Acceptance Criteria

  • Bottom padding added to combobox-item-group at all scales.
  • Added padding would not be present if the group has no items, allowing for the use of only the group heading (with no extra padding) when nesting groups.

Relevant Info

Thank you to @Anastasiia-Boleiko for bringing this to our attention!

A design, with a possible final spec, is available in Figma.

Which Component

Combobox Item Group

Example Use Case

No response

Esri team

Calcite (dev)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 1, 2023
@github-actions github-actions bot added the Calcite (dev) Issues logged by Calcite developers. label Feb 1, 2023
@ashetland ashetland added design Issues that need design consultation prior to development. Calcite (design) Issues logged by Calcite designers. ArcGIS Urban Issues logged by ArcGIS Urban team members. and removed Calcite (dev) Issues logged by Calcite developers. labels Feb 1, 2023
@Anastasiia-Boleiko
Copy link

Thanks a lot for filing this enhancement! It will be really helpful👍

@brittneytewks brittneytewks added c-combobox Issues that pertain to the calcite-combobox and related components p - low Issue is non core or affecting less that 10% of people using the library estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. labels Mar 22, 2023
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Mar 22, 2023
@brittneytewks brittneytewks mentioned this issue Apr 3, 2023
Open
9 tasks
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Apr 17, 2023
@ashetland
Copy link
Contributor Author

Design spec available in this Figma file.

@ashetland ashetland added figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists ready for dev Issues ready for development implementation. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed design Issues that need design consultation prior to development. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 9, 2023
@ashetland ashetland removed their assignment Jun 9, 2023
@geospatialem geospatialem added this to the 2023 July Priorities milestone Jun 22, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 22, 2023
@Elijbet Elijbet self-assigned this Jul 8, 2023
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jul 8, 2023
@Elijbet Elijbet mentioned this issue Jul 9, 2023
Merged
benelan pushed a commit that referenced this issue Aug 3, 2023
@Elijbet
fix(combobox): add space after grouped items (#7302)
b1580c7 
**Related Issue:** #6412

## Summary
Adding space at the bottom of grouped items to provide visual separation
between the group and any following content.

- Bottom padding added to combobox-item-group at all scales.
- Added padding would not be present if the group has no items, allowing
for the use of only the group heading (with no extra padding) when
nesting groups.

<img width="375" alt="CleanShot 2023-07-10 at 09 19 44@2x"
src="https://github.com/Esri/calcite-design-system/assets/19231036/192e1b23-53c0-4a09-8d78-8322d26b99e0">
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 3, 2023
@geospatialem
Copy link
Member

Verified in the main branch:

image

@ashetland ashetland added the design Issues that need design consultation prior to development. label Sep 18, 2023
@SkyeSeitz SkyeSeitz removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@ashetland ashetland

@brittneytewks brittneytewks

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Urban Issues logged by ArcGIS Urban team members. c-combobox Issues that pertain to the calcite-combobox and related components Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
7 participants
@alisonailea @geospatialem @Elijbet @SkyeSeitz @ashetland @brittneytewks @Anastasiia-Boleiko