Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): hide warning and show TestOnly stories in local builds #7424

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

benelan
Copy link
Member

@benelan benelan commented Aug 2, 2023

Related Issue: #7338

Summary

Creates a STORYBOOK_SNAPSHOT_LOCAL_BUILD environment variable and automatically sets it in the docs:preview npm script. When the environment variable is truthy, the storybook build:

  • Hides the warning banner
  • Displays both TestOnly and NoTest stories

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Aug 2, 2023
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Aug 2, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!!!

@benelan benelan merged commit 9a53b6a into main Aug 3, 2023
@benelan benelan deleted the benelan/local-storybook-build-configuration branch August 3, 2023 00:20
@github-actions github-actions bot added this to the 2023 July Priorities milestone Aug 3, 2023
benelan added a commit that referenced this pull request Aug 3, 2023
…lds (#7424)

**Related Issue:** #7338

## Summary

Creates a `STORYBOOK_SNAPSHOT_LOCAL_BUILD` environment variable and
automatically sets it in the `docs:preview` npm script. When the
environment variable is truthy, the storybook build:

- Hides the warning banner
- Displays both TestOnly and NoTest stories
benelan added a commit that referenced this pull request Aug 3, 2023
* origin/main: (40 commits)
  fix(combobox): add space after grouped items (#7302)
  fix(tooltip): emits `close` and `beforeClose` events when container is set to `display:none` (#7258)
  chore: release next
  feat(block): improve block's content layout to allow scrolling (#7367)
  test(input, input-number): await on missed `page.waitForChanges` calls (#7429)
  chore: release next
  fix(color-picker): draw slider thumbs within bounds (#7398)
  chore: release next
  fix(slider): prevent excessive tick rendering (#7421)
  fix(tooltip): avoid extra before open/close event emitting (#7422)
  chore(storybook): hide warning and show TestOnly stories in local builds (#7424)
  chore: release next
  fix(panel): Remove double border styling when content isn't provided (#7368)
  feat(list): Add support for dragging items. (#7109)
  chore: release next
  fix(scrim): update loader scale on resize of component. (#7419)
  feat(text-area): provide additional context for AT users when character limit exceeds (#7412)
  chore: release next
  fix(chip): disconnect mutation observer when component is disconnected from the DOM (#7418)
  fix(switch): Fix for focus outline style in certain cases (#7414)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants