Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooling: restore previous error linting rules #791

Closed
jcfranco opened this issue Jul 30, 2020 · 2 comments
Closed

Tooling: restore previous error linting rules #791

jcfranco opened this issue Jul 30, 2020 · 2 comments
Assignees
@jcfranco
Labels
1 - assigned Issues that are assigned to a sprint and a team member. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Milestone
Freezer

Comments

@jcfranco
Copy link
Member

Summary

#790 downgraded the severity of a few linting rules to port over the same linting from calcite-app-components.

Measure of Success

Previous error rules are restored.

Resources

@jcfranco jcfranco added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. labels Jul 30, 2020
@jcfranco jcfranco added this to the Backlog milestone Jul 30, 2020
@jcfranco jcfranco self-assigned this Jul 30, 2020
@jcfranco jcfranco mentioned this issue Jul 31, 2020
Merged
jcfranco added a commit that referenced this issue Jul 31, 2020
@jcfranco
build(linting): restore eslint rules (#795)
7739e84 
#791
@julio8a julio8a added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 28, 2021
@julio8a julio8a removed the 1 - assigned Issues that are assigned to a sprint and a team member. label Jul 15, 2021
@benelan benelan added the 2 - in development Issues that are actively being worked on. label Aug 31, 2021
@jcfranco jcfranco mentioned this issue Sep 10, 2021
Merged
jcfranco added a commit that referenced this issue Sep 10, 2021
@jcfranco
chore(linting): drop TSLint (#3009)
6e040c9 
* replaces prefer-conditional-expression rule with unicorn/prefer-ternary
* removes remaining tslint-stencil rules used to warn about component/lifecycle order

#791
@jcfranco jcfranco added 0 - new New issues that need assignment. and removed 2 - in development Issues that are actively being worked on. labels Jan 7, 2022
@jcfranco
Copy link
Member Author

jcfranco commented Jan 7, 2022

Gonna put this in the Freezer until the missing tslint-stencil rules are ported to https://github.com/ionic-team/stencil-eslint (see #3009).

@jcfranco jcfranco added the p - low Issue is non core or affecting less that 10% of people using the library label Jan 7, 2022
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 30, 2023
@jcfranco
Copy link
Member Author

This is no longer valid due after #10310. The only rule left to restore will be handled in #10880.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfranco jcfranco

Labels
1 - assigned Issues that are assigned to a sprint and a team member. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
Freezer
Development

No branches or pull requests
5 participants
@jcfranco @alisonailea @geospatialem @julio8a @benelan